Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: chromecast/browser/android/external_video_surface_container_impl.h

Issue 917303002: Clean up redundant virtual specifiers for chromecast android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Change dtor specifiers Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/browser/android/external_video_surface_container_impl.h
diff --git a/chromecast/browser/android/external_video_surface_container_impl.h b/chromecast/browser/android/external_video_surface_container_impl.h
index d87debfaa8abbb14b8f21bfe2d984d5f4fd664c0..434071dbbfe8a72faf7977397513a5feac0dd085 100644
--- a/chromecast/browser/android/external_video_surface_container_impl.h
+++ b/chromecast/browser/android/external_video_surface_container_impl.h
@@ -24,14 +24,14 @@ class ExternalVideoSurfaceContainerImpl
ExternalVideoSurfaceContainerImpl(content::WebContents* contents);
// ExternalVideoSurfaceContainer implementation.
- virtual void RequestExternalVideoSurface(
+ void RequestExternalVideoSurface(
int player_id,
const SurfaceCreatedCB& surface_created_cb,
const SurfaceDestroyedCB& surface_destroyed_cb) override;
- virtual int GetCurrentPlayerId() override;
- virtual void ReleaseExternalVideoSurface(int player_id) override;
- virtual void OnFrameInfoUpdated() override;
- virtual void OnExternalVideoSurfacePositionChanged(
+ int GetCurrentPlayerId() override;
+ void ReleaseExternalVideoSurface(int player_id) override;
+ void OnFrameInfoUpdated() override;
+ void OnExternalVideoSurfacePositionChanged(
int player_id, const gfx::RectF& rect) override;
// Methods called from Java.
@@ -40,7 +40,7 @@ class ExternalVideoSurfaceContainerImpl
void SurfaceDestroyed(JNIEnv* env, jobject obj, jint player_id);
private:
- virtual ~ExternalVideoSurfaceContainerImpl();
+ ~ExternalVideoSurfaceContainerImpl() override;
base::android::ScopedJavaGlobalRef<jobject> jobject_;
« no previous file with comments | « chromecast/browser/android/cast_window_android.h ('k') | chromecast/crash/android/cast_crash_reporter_client_android.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698