Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1023)

Side by Side Diff: chromecast/browser/android/external_video_surface_container_impl.h

Issue 917303002: Clean up redundant virtual specifiers for chromecast android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Change dtor specifiers Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROMECAST_BROWSER_ANDROID_EXTERNAL_VIDEO_SURFACE_CONTAINER_IMPL_H_ 5 #ifndef CHROMECAST_BROWSER_ANDROID_EXTERNAL_VIDEO_SURFACE_CONTAINER_IMPL_H_
6 #define CHROMECAST_BROWSER_ANDROID_EXTERNAL_VIDEO_SURFACE_CONTAINER_IMPL_H_ 6 #define CHROMECAST_BROWSER_ANDROID_EXTERNAL_VIDEO_SURFACE_CONTAINER_IMPL_H_
7 7
8 #include <jni.h> 8 #include <jni.h>
9 9
10 #include "base/android/scoped_java_ref.h" 10 #include "base/android/scoped_java_ref.h"
11 #include "base/callback.h" 11 #include "base/callback.h"
12 #include "base/compiler_specific.h" 12 #include "base/compiler_specific.h"
13 #include "content/public/browser/android/external_video_surface_container.h" 13 #include "content/public/browser/android/external_video_surface_container.h"
14 14
15 namespace chromecast { 15 namespace chromecast {
16 namespace shell { 16 namespace shell {
17 17
18 class ExternalVideoSurfaceContainerImpl 18 class ExternalVideoSurfaceContainerImpl
19 : public content::ExternalVideoSurfaceContainer { 19 : public content::ExternalVideoSurfaceContainer {
20 public: 20 public:
21 typedef base::Callback<void(int, jobject)> SurfaceCreatedCB; 21 typedef base::Callback<void(int, jobject)> SurfaceCreatedCB;
22 typedef base::Callback<void(int)> SurfaceDestroyedCB; 22 typedef base::Callback<void(int)> SurfaceDestroyedCB;
23 23
24 ExternalVideoSurfaceContainerImpl(content::WebContents* contents); 24 ExternalVideoSurfaceContainerImpl(content::WebContents* contents);
25 25
26 // ExternalVideoSurfaceContainer implementation. 26 // ExternalVideoSurfaceContainer implementation.
27 virtual void RequestExternalVideoSurface( 27 void RequestExternalVideoSurface(
28 int player_id, 28 int player_id,
29 const SurfaceCreatedCB& surface_created_cb, 29 const SurfaceCreatedCB& surface_created_cb,
30 const SurfaceDestroyedCB& surface_destroyed_cb) override; 30 const SurfaceDestroyedCB& surface_destroyed_cb) override;
31 virtual int GetCurrentPlayerId() override; 31 int GetCurrentPlayerId() override;
32 virtual void ReleaseExternalVideoSurface(int player_id) override; 32 void ReleaseExternalVideoSurface(int player_id) override;
33 virtual void OnFrameInfoUpdated() override; 33 void OnFrameInfoUpdated() override;
34 virtual void OnExternalVideoSurfacePositionChanged( 34 void OnExternalVideoSurfacePositionChanged(
35 int player_id, const gfx::RectF& rect) override; 35 int player_id, const gfx::RectF& rect) override;
36 36
37 // Methods called from Java. 37 // Methods called from Java.
38 void SurfaceCreated( 38 void SurfaceCreated(
39 JNIEnv* env, jobject obj, jint player_id, jobject jsurface); 39 JNIEnv* env, jobject obj, jint player_id, jobject jsurface);
40 void SurfaceDestroyed(JNIEnv* env, jobject obj, jint player_id); 40 void SurfaceDestroyed(JNIEnv* env, jobject obj, jint player_id);
41 41
42 private: 42 private:
43 virtual ~ExternalVideoSurfaceContainerImpl(); 43 ~ExternalVideoSurfaceContainerImpl() override;
44 44
45 base::android::ScopedJavaGlobalRef<jobject> jobject_; 45 base::android::ScopedJavaGlobalRef<jobject> jobject_;
46 46
47 SurfaceCreatedCB surface_created_cb_; 47 SurfaceCreatedCB surface_created_cb_;
48 SurfaceDestroyedCB surface_destroyed_cb_; 48 SurfaceDestroyedCB surface_destroyed_cb_;
49 49
50 DISALLOW_COPY_AND_ASSIGN(ExternalVideoSurfaceContainerImpl); 50 DISALLOW_COPY_AND_ASSIGN(ExternalVideoSurfaceContainerImpl);
51 }; 51 };
52 52
53 bool RegisterExternalVideoSurfaceContainer(JNIEnv* env); 53 bool RegisterExternalVideoSurfaceContainer(JNIEnv* env);
54 54
55 } // namespace shell 55 } // namespace shell
56 } // namespace chromecast 56 } // namespace chromecast
57 57
58 #endif // CHROMECAST_BROWSER_ANDROID_EXTERNAL_VIDEO_SURFACE_CONTAINER_IMPL_H_ 58 #endif // CHROMECAST_BROWSER_ANDROID_EXTERNAL_VIDEO_SURFACE_CONTAINER_IMPL_H_
OLDNEW
« no previous file with comments | « chromecast/browser/android/cast_window_android.h ('k') | chromecast/crash/android/cast_crash_reporter_client_android.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698