Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 917213003: Clean up for https://codereview.chromium.org/884483006/ (Closed)

Created:
5 years, 10 months ago by Changwan Ryu
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up for https://codereview.chromium.org/884483006/ BUG=430635 Committed: https://crrev.com/b4d84504df5c1a0bda91805ed86d3fdfb732b339 Cr-Commit-Position: refs/heads/master@{#316995}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -52 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java View 1 chunk +0 lines, -17 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenHtmlApiHandler.java View 5 chunks +8 lines, -35 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Changwan Ryu
5 years, 10 months ago (2015-02-13 00:08:52 UTC) #2
Changwan Ryu
David, could you take a quick look? Thanks.
5 years, 10 months ago (2015-02-13 22:19:30 UTC) #3
Changwan Ryu
On 2015/02/13 22:19:30, Changwan Ryu wrote: > David, could you take a quick look? Thanks. ...
5 years, 10 months ago (2015-02-18 06:17:57 UTC) #4
David Trainor- moved to gerrit
lgtm sorry for the delay!
5 years, 10 months ago (2015-02-19 00:55:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/917213003/1
5 years, 10 months ago (2015-02-19 05:24:12 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-19 05:54:29 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b4d84504df5c1a0bda91805ed86d3fdfb732b339 Cr-Commit-Position: refs/heads/master@{#316995}
5 years, 10 months ago (2015-02-19 05:55:02 UTC) #9
Changwan Ryu
5 years, 10 months ago (2015-02-19 08:40:11 UTC) #10
Message was sent while issue was closed.
On 2015/02/19 00:55:14, David Trainor wrote:
> lgtm sorry for the delay!

No problem. Thanks for the review!

Powered by Google App Engine
This is Rietveld 408576698