Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Side by Side Diff: chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java

Issue 917213003: Clean up for https://codereview.chromium.org/884483006/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenHtmlApiHandler.java » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.chrome.browser.fullscreen; 5 package org.chromium.chrome.browser.fullscreen;
6 6
7 import android.animation.Animator; 7 import android.animation.Animator;
8 import android.animation.AnimatorListenerAdapter; 8 import android.animation.AnimatorListenerAdapter;
9 import android.animation.ObjectAnimator; 9 import android.animation.ObjectAnimator;
10 import android.app.Activity; 10 import android.app.Activity;
(...skipping 172 matching lines...) Expand 10 before | Expand all | Expand 10 after
183 } 183 }
184 184
185 /** 185 /**
186 * Creates an instance of the fullscreen mode manager. 186 * Creates an instance of the fullscreen mode manager.
187 * @param activity The activity that supports fullscreen. 187 * @param activity The activity that supports fullscreen.
188 * @param controlContainer Container holding the controls (Toolbar). 188 * @param controlContainer Container holding the controls (Toolbar).
189 * @param enabled Whether fullscreen is globally enabled. 189 * @param enabled Whether fullscreen is globally enabled.
190 * @param persistentFullscreenSupported Whether persistent fullscreen mode i s supported. 190 * @param persistentFullscreenSupported Whether persistent fullscreen mode i s supported.
191 * @param modelSelector The model selector providing access to the current t ab. 191 * @param modelSelector The model selector providing access to the current t ab.
192 * @param resControlContainerHeight The dimension resource ID for the contro l container height. 192 * @param resControlContainerHeight The dimension resource ID for the contro l container height.
193 */
194 // TODO(changwan): remove
195 public ChromeFullscreenManager(Activity activity, View controlContainer, boo lean enabled,
196 boolean persistentFullscreenSupported, TabModelSelector modelSelecto r,
197 int resControlContainerHeight) {
198 this(activity, controlContainer, enabled, persistentFullscreenSupported,
199 modelSelector, resControlContainerHeight, true);
200 }
201
202 /**
203 * Creates an instance of the fullscreen mode manager.
204 * @param activity The activity that supports fullscreen.
205 * @param controlContainer Container holding the controls (Toolbar).
206 * @param enabled Whether fullscreen is globally enabled.
207 * @param persistentFullscreenSupported Whether persistent fullscreen mode i s supported.
208 * @param modelSelector The model selector providing access to the current t ab.
209 * @param resControlContainerHeight The dimension resource ID for the contro l container height.
210 * @param supportsBrowserOverride Whether we want to disable the token syste m used by the 193 * @param supportsBrowserOverride Whether we want to disable the token syste m used by the
211 browser. 194 browser.
212 */ 195 */
213 public ChromeFullscreenManager(Activity activity, View controlContainer, boo lean enabled, 196 public ChromeFullscreenManager(Activity activity, View controlContainer, boo lean enabled,
214 boolean persistentFullscreenSupported, TabModelSelector modelSelecto r, 197 boolean persistentFullscreenSupported, TabModelSelector modelSelecto r,
215 int resControlContainerHeight, boolean supportsBrowserOverride) { 198 int resControlContainerHeight, boolean supportsBrowserOverride) {
216 super(activity.getWindow(), modelSelector, enabled, persistentFullscreen Supported); 199 super(activity.getWindow(), modelSelector, enabled, persistentFullscreen Supported);
217 200
218 mActivity = activity; 201 mActivity = activity;
219 ApplicationStatus.registerStateListenerForActivity(this, activity); 202 ApplicationStatus.registerStateListenerForActivity(this, activity);
(...skipping 569 matching lines...) Expand 10 before | Expand all | Expand 10 after
789 mControlAnimation.start(); 772 mControlAnimation.start();
790 mCurrentAnimationIsShowing = show; 773 mCurrentAnimationIsShowing = show;
791 } 774 }
792 775
793 @Override 776 @Override
794 public void onContentViewScrollingStateChanged(boolean scrolling) { 777 public void onContentViewScrollingStateChanged(boolean scrolling) {
795 mContentViewScrolling = scrolling; 778 mContentViewScrolling = scrolling;
796 if (!scrolling) updateVisuals(); 779 if (!scrolling) updateVisuals();
797 } 780 }
798 } 781 }
OLDNEW
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenHtmlApiHandler.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698