Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(733)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 917203002: Subzero: Generate a web page showing llvm2ice size breakdown. (Closed)

Created:
5 years, 10 months ago by Jim Stichnoth
Modified:
5 years, 10 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Generate a web page showing llvm2ice size breakdown. "make -f Makefile.standalone bloat" generates a json file containing ./llvm2ice size data, and launches google-chrome on the output. bloat.py is taken verbatim from https://github.com/martine/bloat/blob/master/bloat.py . webtreemap.{js,css} are taken verbatim from https://github.com/martine/webtreemap . llvm2ice.bloat.html is adapted from https://github.com/martine/webtreemap/blob/gh-pages/demo/demo.html . BUG= none R=jfb@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=307e326f90e8990361ad30645eb0bc80180c097b

Patch Set 1 #

Total comments: 10

Patch Set 2 : Add legend. Add third-party README. Fix html. #

Total comments: 6

Patch Set 3 : Fix html #

Patch Set 4 : Dump the json file into the build directory #

Unified diffs Side-by-side diffs Delta from patch set Stats (+852 lines, -2 lines) Patch
M Makefile.standalone View 1 2 3 2 chunks +7 lines, -2 lines 0 comments Download
A bloat/README.chromium View 1 1 chunk +35 lines, -0 lines 0 comments Download
A bloat/bloat.py View 1 chunk +433 lines, -0 lines 0 comments Download
A bloat/llvm2ice.bloat.html View 1 2 3 1 chunk +61 lines, -0 lines 0 comments Download
A bloat/webtreemap.css View 1 chunk +84 lines, -0 lines 0 comments Download
A bloat/webtreemap.js View 1 chunk +232 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
Jim Stichnoth
I wish I could figure out how to include a legend for the color-coding.
5 years, 10 months ago (2015-02-12 15:40:26 UTC) #2
JF
On 2015/02/12 15:40:26, stichnot wrote: > I wish I could figure out how to include ...
5 years, 10 months ago (2015-02-12 17:13:07 UTC) #3
JF
bloat and webtreemap should contain info on where the repo is from, and which version. ...
5 years, 10 months ago (2015-02-12 17:20:28 UTC) #4
Jim Stichnoth
https://codereview.chromium.org/917203002/diff/1/Makefile.standalone File Makefile.standalone (right): https://codereview.chromium.org/917203002/diff/1/Makefile.standalone#newcode220 Makefile.standalone:220: google-chrome --incognito bloat/llvm2ice.bloat.html On 2015/02/12 17:20:28, JF wrote: > ...
5 years, 10 months ago (2015-02-12 18:39:50 UTC) #5
JF
https://codereview.chromium.org/917203002/diff/20001/Makefile.standalone File Makefile.standalone (right): https://codereview.chromium.org/917203002/diff/20001/Makefile.standalone#newcode220 Makefile.standalone:220: @echo See Subzero size breakdown in bloat/llvm2ice.bloat.html Won't that ...
5 years, 10 months ago (2015-02-12 19:27:41 UTC) #6
Jim Stichnoth
https://codereview.chromium.org/917203002/diff/20001/Makefile.standalone File Makefile.standalone (right): https://codereview.chromium.org/917203002/diff/20001/Makefile.standalone#newcode220 Makefile.standalone:220: @echo See Subzero size breakdown in bloat/llvm2ice.bloat.html On 2015/02/12 ...
5 years, 10 months ago (2015-02-12 21:06:14 UTC) #7
JF
On 2015/02/12 21:06:14, stichnot wrote: > https://codereview.chromium.org/917203002/diff/20001/Makefile.standalone > File Makefile.standalone (right): > > https://codereview.chromium.org/917203002/diff/20001/Makefile.standalone#newcode220 > ...
5 years, 10 months ago (2015-02-12 22:22:17 UTC) #8
Jim Stichnoth
On 2015/02/12 22:22:17, JF wrote: > On 2015/02/12 21:06:14, stichnot wrote: > > https://codereview.chromium.org/917203002/diff/20001/Makefile.standalone > ...
5 years, 10 months ago (2015-02-13 00:10:12 UTC) #10
Jim Stichnoth
5 years, 10 months ago (2015-02-13 00:10:41 UTC) #11
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
307e326f90e8990361ad30645eb0bc80180c097b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698