Issue 917033002: Redo "Steps towards making dart2js JS AST templates an indepentent library."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 917033002: Redo "Steps towards making dart2js JS AST templates an indepentent library." (Closed)

Created:
5 years, 10 months ago by sra1

Modified:
5 years, 10 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org, ahe

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

Redo "Steps towards making dart2js JS AST templates an indepentent library." Adds fix for dart2js_incremental TBR=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=43712

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+225 lines, -180 lines)			Patch
M	pkg/compiler/lib/src/io/source_information.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/js/builder.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	pkg/compiler/lib/src/js/characters.dart	View		2 chunks	+2 lines, -28 lines	0 comments	Download
M	pkg/compiler/lib/src/js/js.dart	View		1 chunk	+53 lines, -12 lines	0 comments	Download
A +	pkg/compiler/lib/src/js/js_ast.dart	View		1 chunk	+7 lines, -3 lines	0 comments	Download
M	pkg/compiler/lib/src/js/nodes.dart	View		10 chunks	+19 lines, -32 lines	0 comments	Download
M	pkg/compiler/lib/src/js/printer.dart	View		14 chunks	+113 lines, -73 lines	0 comments	Download
M	pkg/compiler/lib/src/js/rewrite_async.dart	View		2 chunks	+0 lines, -10 lines	0 comments	Download
M	pkg/compiler/lib/src/js/template.dart	View		4 chunks	+5 lines, -8 lines	0 comments	Download
M	pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/compiler/lib/src/use_unused_api.dart	View		2 chunks	+9 lines, -5 lines	0 comments	Download
M	pkg/dart2js_incremental/lib/library_updater.dart	View	1	1 chunk	+6 lines, -2 lines	0 comments	Download
M	tests/compiler/dart2js/async_await_js_transform_test.dart	View		2 chunks	+6 lines, -3 lines	0 comments	Download

Total messages: 2 (0 generated)

sra1

Committed patchset #3 (id:30001) manually as 43712 (presubmit successful).

5 years, 10 months ago (2015-02-12 01:58:24 UTC) #1

Message was sent while issue was closed.

LGTM.