Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 916973003: Rename the members of FrameReceiverConfig (Closed)

Created:
5 years, 10 months ago by zhuoyu.qian
Modified:
5 years, 9 months ago
Reviewers:
miu
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename the members of FrameReceiverConfig TODO(miu): rename feedback_ssrc to receiver_ssrc; rename incoming_ssrc to sender_ssrc. BUG= R=miu@chromium.org Committed: https://crrev.com/f2b52ebeaa5ad1d3f06c0597a830b56bfcc9dc86 Cr-Commit-Position: refs/heads/master@{#318314}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -32 lines) Patch
M media/cast/cast_config.h View 1 chunk +2 lines, -2 lines 0 comments Download
M media/cast/cast_config.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/cast/receiver/cast_receiver_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/cast/receiver/frame_receiver.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M media/cast/receiver/frame_receiver_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/test/cast_benchmarks.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M media/cast/test/end2end_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M media/cast/test/receiver.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M media/cast/test/utility/default_config.cc View 4 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
zhuoyu.qian
5 years, 10 months ago (2015-02-16 06:07:18 UTC) #1
zhuoyu.qian
Hi miu, Please have a look. Thank you.
5 years, 9 months ago (2015-02-26 07:15:40 UTC) #3
miu
lgtm
5 years, 9 months ago (2015-02-26 20:12:17 UTC) #5
miu
Thanks for the clean-up work! :)
5 years, 9 months ago (2015-02-26 20:12:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/916973003/1
5 years, 9 months ago (2015-02-26 20:13:33 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-02-26 21:24:09 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-02-26 21:25:21 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f2b52ebeaa5ad1d3f06c0597a830b56bfcc9dc86
Cr-Commit-Position: refs/heads/master@{#318314}

Powered by Google App Engine
This is Rietveld 408576698