Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 916953002: Merge to XFA: CPDF_Object() constructor should set its internal m_Type variable. (Closed)

Created:
5 years, 10 months ago by Tom Sepez
Modified:
5 years, 10 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Merge to XFA: CPDF_Object() constructor should set its internal m_Type variable. Original Review URL: https://codereview.chromium.org/880233005 TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/0e8141a8d3d2c1ed51561815ac26e5bba801a629

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -87 lines) Patch
M core/include/fpdfapi/fpdf_objects.h View 9 chunks +18 lines, -65 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp View 4 chunks +13 lines, -22 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Tom Sepez
5 years, 10 months ago (2015-02-11 20:56:41 UTC) #1
Tom Sepez
Committed patchset #1 (id:1) manually as 0e8141a8d3d2c1ed51561815ac26e5bba801a629 (presubmit successful).
5 years, 10 months ago (2015-02-11 20:56:56 UTC) #2
Lei Zhang
5 years, 10 months ago (2015-02-11 21:23:25 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698