CPDF_Object() constructor should set its internal m_Type variable.

CPDF_Object() constructor should set its internal m_Type variable.


Follow-on from https://codereview.chromium.org/911293002/

Currently, all the subclass constructors are reaching up
into the parent class to do this.  Fix this, just because.

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/6e7ceb8225de25b66d27d620c9521e19de023504

[Tom Sepez, 2015-02-11 00:49:47]

tsepez@chromium.org changed reviewers:
+ jun_fang@foxitsoftware.com, thestig@chromium.org

[Tom Sepez, 2015-02-11 00:50:13]

Lei, Jun, please review.

[Lei Zhang, 2015-02-11 01:02:37]

lgtm

https://codereview.chromium.org/880233005/diff/20001/core/include/fpdfapi/fpd...
File core/include/fpdfapi/fpdf_objects.h (right):

https://codereview.chromium.org/880233005/diff/20001/core/include/fpdfapi/fpd...
core/include/fpdfapi/fpdf_objects.h:94: CPDF_Object(FX_DWORD type) :
m_Type(type), m_ObjNum(0), m_GenNum(0) { }
Add "explicit" while we are at it? Ditto below.

https://codereview.chromium.org/880233005/diff/20001/core/src/fpdfapi/fpdf_pa...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp (right):

https://codereview.chromium.org/880233005/diff/20001/core/src/fpdfapi/fpdf_pa...
core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp:370:
CPDF_String::CPDF_String(const CFX_WideString& str) :
CPDF_Object(PDFOBJ_STRING), m_bHex(FALSE) {
Avoid going over 80 chars?

[jun_fang, 2015-02-11 01:18:03]

https://codereview.chromium.org/880233005/diff/20001/core/include/fpdfapi/fpd...
File core/include/fpdfapi/fpdf_objects.h (right):

https://codereview.chromium.org/880233005/diff/20001/core/include/fpdfapi/fpd...
core/include/fpdfapi/fpdf_objects.h:94: CPDF_Object(FX_DWORD type) :
m_Type(type), m_ObjNum(0), m_GenNum(0) { }
Before this patch, CPDF_Object has a constructor function without any
parameters. In this patch, you add a parameter in this constructor. Are you sure
that this change doesn't have impact on other codes?

[Tom Sepez, 2015-02-11 20:40:22]

New patchsets have been uploaded after l-g-t-m from thestig@chromium.org

[Tom Sepez, 2015-02-11 20:41:13]

> Before this patch, CPDF_Object has a constructor function without any
> parameters. In this patch, you add a parameter in this constructor. Are you
sure
> that this change doesn't have impact on other codes?
Yep, it would fail to compile if I didn't fix all the places where this is
invoked.

[Tom Sepez, 2015-02-11 20:42:31]

On 2015/02/11 01:02:37, Lei Zhang wrote:
> lgtm
> 
>
https://codereview.chromium.org/880233005/diff/20001/core/include/fpdfapi/fpd...
> File core/include/fpdfapi/fpdf_objects.h (right):
> 
>
https://codereview.chromium.org/880233005/diff/20001/core/include/fpdfapi/fpd...
> core/include/fpdfapi/fpdf_objects.h:94: CPDF_Object(FX_DWORD type) :
> m_Type(type), m_ObjNum(0), m_GenNum(0) { }
> Add "explicit" while we are at it? Ditto below.
> 
>
https://codereview.chromium.org/880233005/diff/20001/core/src/fpdfapi/fpdf_pa...
> File core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp (right):
> 
>
https://codereview.chromium.org/880233005/diff/20001/core/src/fpdfapi/fpdf_pa...
> core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp:370:
> CPDF_String::CPDF_String(const CFX_WideString& str) :
> CPDF_Object(PDFOBJ_STRING), m_bHex(FALSE) {
> Avoid going over 80 chars?
I've not been really uptight about this given that there's a clang-format coming
down the road (someday???) and that the rest of the code is well over 80.

[Tom Sepez, 2015-02-11 20:44:08]

Committed patchset #3 (id:40001) manually as
6e7ceb8225de25b66d27d620c9521e19de023504 (presubmit successful).