Add a Preference to allow WebRTC only bind to "any address" (all 0s)

Add a Preference to allow WebRTC only bind to "any address" (all 0s). This way, no local IP or private ISP's public IP leaked when VPN is the default route.

Add webrtc.multiple_routes_enabled preference to RendererPreferences. Default is true. When set to false, a new port allocator flag will be passed to P2PPortAllocator which will have WebRTC only bind to all 0s (any address) IP and the default route will be used as how chrome/http is routed.

Each rtc_peer_connection_handler is associated with a WebFrame and it leads to a webview and then the mapping RenderViewImpl which has RendererPreferences that we care.

The corresponding webrtc change is at https://webrtc-codereview.appspot.com/39129004

BUG=333752
Committed: https://crrev.com/7c98bab02128ae9fdc4fcc9a9df38588af86290e
Cr-Commit-Position: refs/heads/master@{#317047}

[guoweis_left_chromium, 2015-02-18 04:40:42]

guoweis@chromium.org changed reviewers:
+ creis@chromium.org, juberti@chromium.org, perkj@chromium.org,
sky@chromium.org, wfh@chromium.org

[guoweis_left_chromium, 2015-02-18 04:40:43]

wfh@chromium.org: Please review changes in view_message.h

sky@chromium.org: Please review changes in chrome/*

juberti@chromium.org: Please review changes in content/renderer/p2p/*

perkj@chromium.org: Please review changes in content/renderer/media/*

creis@chromium.org: Please review changes in content/public/common/*

[guoweis_left_chromium, 2015-02-18 04:41:40]

On 2015/02/18 04:40:43, guoweis_chromium wrote:
> mailto:wfh@chromium.org: Please review changes in view_message.h
> 
> mailto:sky@chromium.org: Please review changes in chrome/*
> 
> mailto:juberti@chromium.org: Please review changes in content/renderer/p2p/*
> 
> mailto:perkj@chromium.org: Please review changes in content/renderer/media/*
> 
> mailto:creis@chromium.org: Please review changes in content/public/common/*

Btw, would like to get this to M42. The corresponding webrtc change should be
rolled into chrome by 2/20. Your timely response is appreciated.

[juberti2, 2015-02-18 07:01:55]

p2p code lgtm

https://codereview.chromium.org/916873004/diff/1/chrome/browser/ui/browser_ui...
File chrome/browser/ui/browser_ui_prefs.cc (right):

https://codereview.chromium.org/916873004/diff/1/chrome/browser/ui/browser_ui...
chrome/browser/ui/browser_ui_prefs.cc:162: prefs::kWebRTCMultipleRoutesDisabled,
probably clearer to have kWebRTCMultipleRoutesEnabled, defaulting to 'true' (no
double-negative)

[perkj_chrome, 2015-02-18 08:10:08]

https://codereview.chromium.org/916873004/diff/1/content/renderer/media/webrt...
File content/renderer/media/webrtc/peer_connection_dependency_factory.cc
(right):

https://codereview.chromium.org/916873004/diff/1/content/renderer/media/webrt...
content/renderer/media/webrtc/peer_connection_dependency_factory.cc:395:
blink::WebFrame* web_frame,
Here you have the web_frame. Please read the prefs from here and remove the
member variable disable_multiple_routes_ from PeerConnectionDependencyFactory
and PeerConnectionHandler. 

It would do the exact same thing since you anyway read it for every
PeerConnection you create.

[Will Harris, 2015-02-18 08:23:51]

ipc messages lgtm

[guoweis_left_chromium, 2015-02-18 12:27:44]

New patchsets have been uploaded after l-g-t-m from
juberti@chromium.org,wfh@chromium.org

[guoweis_left_chromium, 2015-02-18 12:30:23]

On 2015/02/18 08:23:51, Will Harris wrote:
> ipc messages lgtm

Perkj, PTAL.

[perkj_chrome, 2015-02-18 12:47:21]

media/ lgtm

[guoweis_left_chromium, 2015-02-18 13:26:46]

New patchsets have been uploaded after l-g-t-m from perkj@chromium.org

[guoweis_left_chromium, 2015-02-18 13:27:22]

Patchset #3 (id:40001) has been deleted

[juberti2, 2015-02-18 18:41:55]

On 2015/02/18 12:47:21, perkj wrote:
> media/ lgtm

lgtm

[Charlie Reis, 2015-02-18 19:01:47]

content/common LGTM

[Charlie Reis, 2015-02-18 19:02:10]

On 2015/02/18 19:01:47, Charlie Reis wrote:
> content/common LGTM

rather, content/public/common LGTM

[guoweis_left_chromium, 2015-02-18 19:17:02]

guoweis@chromium.org changed reviewers:
- sky@chromium.org

[guoweis_left_chromium, 2015-02-18 19:20:34]

guoweis@chromium.org changed reviewers:
+ thakis@chromium.org
- creis@chromium.org, juberti@chromium.org, perkj@chromium.org, wfh@chromium.org

[guoweis_left_chromium, 2015-02-18 19:20:36]

thakis@chromium.org: Please review changes in chrome/*

https://codereview.chromium.org/916873004/diff/1/chrome/browser/ui/browser_ui...
File chrome/browser/ui/browser_ui_prefs.cc (right):

https://codereview.chromium.org/916873004/diff/1/chrome/browser/ui/browser_ui...
chrome/browser/ui/browser_ui_prefs.cc:162: prefs::kWebRTCMultipleRoutesDisabled,
On 2015/02/18 07:01:55, juberti2 wrote:
> probably clearer to have kWebRTCMultipleRoutesEnabled, defaulting to 'true'
(no
> double-negative)

Done.

https://codereview.chromium.org/916873004/diff/1/content/renderer/media/webrt...
File content/renderer/media/webrtc/peer_connection_dependency_factory.cc
(right):

https://codereview.chromium.org/916873004/diff/1/content/renderer/media/webrt...
content/renderer/media/webrtc/peer_connection_dependency_factory.cc:395:
blink::WebFrame* web_frame,
On 2015/02/18 08:10:08, perkj wrote:
> Here you have the web_frame. Please read the prefs from here and remove the
> member variable disable_multiple_routes_ from PeerConnectionDependencyFactory
> and PeerConnectionHandler. 
> 
> It would do the exact same thing since you anyway read it for every
> PeerConnection you create.

Done.

[guoweis_left_chromium, 2015-02-18 19:21:41]

PTAL chrome/*

[Nico, 2015-02-18 19:28:01]

chrome lgtm from a code point of view, but I don't understand how this pref is
going to be set. (It won't end up on chrome://settings/ as it's much too
technical for that, so what else is going to set it?)

[guoweis_left_chromium, 2015-02-18 19:36:12]

On 2015/02/18 19:28:01, Nico wrote:
> chrome lgtm from a code point of view, but I don't understand how this pref is
> going to be set. (It won't end up on chrome://settings/ as it's much too
> technical for that, so what else is going to set it?)

The current plan is that we'll add a chrome extension to set this preference
given that most of users won't need to set this, only those who are super
sensitive about being tracked by their local IP.

[Nico, 2015-02-18 19:45:41]

On 2015/02/18 19:36:12, guoweis_chromium wrote:
> On 2015/02/18 19:28:01, Nico wrote:
> > chrome lgtm from a code point of view, but I don't understand how this pref
is
> > going to be set. (It won't end up on chrome://settings/ as it's much too
> > technical for that, so what else is going to set it?)
> 
> The current plan is that we'll add a chrome extension to set this preference
> given that most of users won't need to set this, only those who are super
> sensitive about being tracked by their local IP.

Hm, that doesn't sound like the most convincing of plans to me, but ok.

[sky, 2015-02-18 22:18:37]

sky@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2015-02-18 22:18:37]

chrome LGTM

[guoweis_left_chromium, 2015-02-19 06:45:16]

New patchsets have been uploaded after l-g-t-m from
juberti@chromium.org,creis@chromium.org,thakis@chromium.org,sky@chromium.org

[guoweis_left_chromium, 2015-02-19 06:47:44]

The CQ bit was checked by guoweis@chromium.org

[commit-bot: I haz the power, 2015-02-19 06:49:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/916873004/80001

[guoweis_left_chromium, 2015-02-19 07:06:28]

The CQ bit was checked by guoweis@chromium.org

[commit-bot: I haz the power, 2015-02-19 07:06:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/916873004/100001

[commit-bot: I haz the power, 2015-02-19 07:20:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-19 07:20:23]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[guoweis_left_chromium, 2015-02-19 14:25:31]

The CQ bit was checked by guoweis@chromium.org

[commit-bot: I haz the power, 2015-02-19 14:26:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/916873004/100001

[commit-bot: I haz the power, 2015-02-19 14:54:59]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2015-02-19 14:55:43]

Patchset 5 (id:??) landed as
https://crrev.com/7c98bab02128ae9fdc4fcc9a9df38588af86290e
Cr-Commit-Position: refs/heads/master@{#317047}