Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 916873002: Fix nasty off-by-one in the TurboFan JSON tracer. (Closed)

Created:
5 years, 10 months ago by Michael Starzinger
Modified:
5 years, 10 months ago
Reviewers:
titzer, danno
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix nasty off-by-one in the TurboFan JSON tracer. R=danno@chromium.org TEST=cctest/test-run-intrinsics/CallFunction Committed: https://crrev.com/34c1db2fd724d886da9e732b234a05d4262fee89 Cr-Commit-Position: refs/heads/master@{#26604}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/compiler/pipeline.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
5 years, 10 months ago (2015-02-11 17:43:32 UTC) #1
titzer
lgtm
5 years, 10 months ago (2015-02-11 18:37:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/916873002/1
5 years, 10 months ago (2015-02-12 08:57:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-12 09:16:24 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 09:16:42 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/34c1db2fd724d886da9e732b234a05d4262fee89
Cr-Commit-Position: refs/heads/master@{#26604}

Powered by Google App Engine
This is Rietveld 408576698