src/compiler/pipeline.cc - Issue 916873002: Fix nasty off-by-one in the TurboFan JSON tracer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/pipeline.cc

Issue 916873002: Fix nasty off-by-one in the TurboFan JSON tracer. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/pipeline.cc

diff --git a/src/compiler/pipeline.cc b/src/compiler/pipeline.cc

index 8c057790bdd693450925611fef034983a2104cd4..b105a317c20a2bc79f18a0a1869e2b77c62e184e 100644

--- a/src/compiler/pipeline.cc

+++ b/src/compiler/pipeline.cc

@@ -838,7 +838,7 @@ Handle<Code> Pipeline::GenerateCode() {

if (!script->IsUndefined() && !script->source()->IsUndefined()) {

DisallowHeapAllocation no_allocation;

int start = function->start_position();

- int len = function->end_position() - start + 1;

+ int len = function->end_position() - start;

String::SubStringRange source(String::cast(script->source()), start,

len);

for (const auto& c : source) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »