Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Unified Diff: components/enhanced_bookmarks/bookmark_image_service.cc

Issue 916783003: Restrict salient image size before storing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/enhanced_bookmarks/bookmark_image_service.cc
diff --git a/components/enhanced_bookmarks/bookmark_image_service.cc b/components/enhanced_bookmarks/bookmark_image_service.cc
index 683ae6e9314127cf95356e5fd81e2ae74a6c0e5f..960b9aaceb9e918223a615c7c6521caa8618003a 100644
--- a/components/enhanced_bookmarks/bookmark_image_service.cc
+++ b/components/enhanced_bookmarks/bookmark_image_service.cc
@@ -190,8 +190,21 @@ void BookmarkImageService::SalientImageForUrl(const GURL& page_url,
void BookmarkImageService::ProcessNewImage(const GURL& page_url,
bool update_bookmarks,
- const gfx::Image& image,
- const GURL& image_url) {
+ const GURL& image_url,
+ const gfx::Image& image) {
+ DCHECK(CalledOnValidThread());
+ base::Callback<gfx::Image(void)> task = base::Bind(
+ &BookmarkImageService::ResizeImage, base::Unretained(this), image);
Kibeom Kim (inactive) 2015/02/12 23:24:15 How about just resizing inside BookmarkImageServic
Ian Wen 2015/02/13 00:52:41 Done.
+ base::Callback<void(const gfx::Image&)> reply =
+ base::Bind(&BookmarkImageService::ProcessNewImageInternal,
+ base::Unretained(this), page_url, update_bookmarks, image_url);
+ base::PostTaskAndReplyWithResult(pool_.get(), FROM_HERE, task, reply);
+}
+
+void BookmarkImageService::ProcessNewImageInternal(const GURL& page_url,
+ bool update_bookmarks,
+ const GURL& image_url,
+ const gfx::Image& image) {
DCHECK(CalledOnValidThread());
PostTaskToStoreImage(image, image_url, page_url);
if (update_bookmarks && image_url.is_valid()) {

Powered by Google App Engine
This is Rietveld 408576698