Restrict salient image size before storing

components/enhanced_bookmarks/bookmark_image_service.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/enhanced_bookmarks/bookmark_image_service.h"
 
 #include "base/single_thread_task_runner.h"
 #include "base/task_runner_util.h"
 #include "base/thread_task_runner_handle.h"
 #include "base/threading/sequenced_worker_pool.h"
@@ skipping 172 matching lines @@
     RetrieveImageFromStore(page_url,
                            base::Bind(&BookmarkImageService::FetchCallback,
                                       base::Unretained(this),
                                       page_url,
                                       callback));
   }
 }
 
 void BookmarkImageService::ProcessNewImage(const GURL& page_url,
                                            bool update_bookmarks,
-                                           const gfx::Image& image,
-                                           const GURL& image_url) {
+                                           const GURL& image_url,
+                                           const gfx::Image& image) {
+  DCHECK(CalledOnValidThread());
+  base::Callback<gfx::Image(void)> task = base::Bind(
+      &BookmarkImageService::ResizeImage, base::Unretained(this), image);

[Kibeom Kim (inactive), 2015/02/12 23:24:15]

How about just resizing inside BookmarkImageService::StoreImage then we don't
need to post another task or make |ProcessNewImageInternal|. (need to change
|StoreImage| function name if we do that.)

[Ian Wen, 2015/02/13 00:52:41]

Done.

+  base::Callback<void(const gfx::Image&)> reply =
+      base::Bind(&BookmarkImageService::ProcessNewImageInternal,
+                 base::Unretained(this), page_url, update_bookmarks, image_url);
+  base::PostTaskAndReplyWithResult(pool_.get(), FROM_HERE, task, reply);
+}
+
+void BookmarkImageService::ProcessNewImageInternal(const GURL& page_url,
+                                                   bool update_bookmarks,
+                                                   const GURL& image_url,
+                                                   const gfx::Image& image) {
   DCHECK(CalledOnValidThread());
   PostTaskToStoreImage(image, image_url, page_url);
   if (update_bookmarks && image_url.is_valid()) {
     const BookmarkNode* bookmark =
         enhanced_bookmark_model_->bookmark_model()
             ->GetMostRecentlyAddedUserNodeForURL(page_url);
     if (bookmark) {
       const gfx::Size& size = image.Size();
       bool result = enhanced_bookmark_model_->SetOriginalImage(
           bookmark, image_url, size.width(), size.height());
@@ skipping 154 matching lines @@
     const BookmarkNode* node) {
 }
 
 void BookmarkImageService::BookmarkAllUserNodesRemoved(
     BookmarkModel* model,
     const std::set<GURL>& removed_urls) {
   ClearAll();
 }
 
 }  // namespace enhanced_bookmarks