Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1290)

Unified Diff: src/api.cc

Issue 916753002: remove undetectable strings (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/v8.h ('k') | src/heap/heap.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index 304d880d3da3017f3f21a8a3b39b3ccc9456c09f..8716b4a0d8550d184676ccbcff4630e34b763227 100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -5432,7 +5432,7 @@ inline Local<String> NewString(Isolate* v8_isolate,
int length) {
i::Isolate* isolate = reinterpret_cast<internal::Isolate*>(v8_isolate);
LOG_API(isolate, env);
- if (length == 0 && type != String::kUndetectableString) {
+ if (length == 0) {
return String::Empty(v8_isolate);
}
ENTER_V8(isolate);
@@ -5442,9 +5442,6 @@ inline Local<String> NewString(Isolate* v8_isolate,
isolate->factory(),
type,
i::Vector<const Char>(data, length)).ToHandleChecked();
- if (type == String::kUndetectableString) {
- result->MarkAsUndetectable();
- }
return Utils::ToLocal(result);
}
« no previous file with comments | « include/v8.h ('k') | src/heap/heap.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698