Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 916223004: Revert of Add DeadlineOverrun step to the RendererSchedulerIdlePeriod trace event. (Closed)

Created:
5 years, 10 months ago by gab
Modified:
5 years, 10 months ago
Reviewers:
dsinclair, nduca, Sami, rmcilroy
CC:
chromium-reviews, darin-cc_chromium.org, dsinclair+watch_chromium.org, erikwright+watch_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, scheduler-bugs_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add DeadlineOverrun step to the RendererSchedulerIdlePeriod trace event. (patchset #1 id:1 of https://codereview.chromium.org/908473002/) Reason for revert: http://crbug.com/456940#c17 Original issue's description: > Add DeadlineOverrun step to the RendererSchedulerIdlePeriod trace event. > > Adds a deadline overrun step to the RendererSchedulerIdlePeriod trace event > to make it obvious when an idle period lasts longer than its deadline. > > Also adds a TRACE_EVENT_ASYNC_STEP_INTO_WITH_TIMESTAMP0 which is required > to add the step at the appropriate time. > > BUG=455713 > > Committed: https://crrev.com/a38b72b5f1ec147bb961e9045ca0c165f428d5e4 > Cr-Commit-Position: refs/heads/master@{#315042} TBR=nduca@chromium.org,skyostil@chromium.org,dsinclair@chromium.org,rmcilroy@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=455713, 456940 Committed: https://crrev.com/58c1206d7b8cacb0e59e14fcd8b21a41a2b5945d Cr-Commit-Position: refs/heads/master@{#315989}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -19 lines) Patch
M base/trace_event/trace_event.h View 1 chunk +0 lines, -9 lines 0 comments Download
M content/renderer/scheduler/renderer_scheduler_impl.cc View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
gab
Created Revert of Add DeadlineOverrun step to the RendererSchedulerIdlePeriod trace event.
5 years, 10 months ago (2015-02-12 16:14:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/916223004/1
5 years, 10 months ago (2015-02-12 16:14:28 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-12 16:14:43 UTC) #4
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 16:15:38 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/58c1206d7b8cacb0e59e14fcd8b21a41a2b5945d
Cr-Commit-Position: refs/heads/master@{#315989}

Powered by Google App Engine
This is Rietveld 408576698