Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Side by Side Diff: content/renderer/scheduler/renderer_scheduler_impl.cc

Issue 916223004: Revert of Add DeadlineOverrun step to the RendererSchedulerIdlePeriod trace event. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/trace_event/trace_event.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/scheduler/renderer_scheduler_impl.h" 5 #include "content/renderer/scheduler/renderer_scheduler_impl.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/message_loop/message_loop_proxy.h" 8 #include "base/message_loop/message_loop_proxy.h"
9 #include "base/trace_event/trace_event.h" 9 #include "base/trace_event/trace_event.h"
10 #include "base/trace_event/trace_event_argument.h" 10 #include "base/trace_event/trace_event_argument.h"
(...skipping 232 matching lines...) Expand 10 before | Expand all | Expand 10 after
243 void RendererSchedulerImpl::StartIdlePeriod() { 243 void RendererSchedulerImpl::StartIdlePeriod() {
244 TRACE_EVENT_ASYNC_BEGIN0("renderer.scheduler", 244 TRACE_EVENT_ASYNC_BEGIN0("renderer.scheduler",
245 "RendererSchedulerIdlePeriod", this); 245 "RendererSchedulerIdlePeriod", this);
246 main_thread_checker_.CalledOnValidThread(); 246 main_thread_checker_.CalledOnValidThread();
247 renderer_task_queue_selector_->EnableQueue( 247 renderer_task_queue_selector_->EnableQueue(
248 IDLE_TASK_QUEUE, RendererTaskQueueSelector::BEST_EFFORT_PRIORITY); 248 IDLE_TASK_QUEUE, RendererTaskQueueSelector::BEST_EFFORT_PRIORITY);
249 task_queue_manager_->PumpQueue(IDLE_TASK_QUEUE); 249 task_queue_manager_->PumpQueue(IDLE_TASK_QUEUE);
250 } 250 }
251 251
252 void RendererSchedulerImpl::EndIdlePeriod() { 252 void RendererSchedulerImpl::EndIdlePeriod() {
253 bool is_tracing;
254 TRACE_EVENT_CATEGORY_GROUP_ENABLED("renderer.scheduler", &is_tracing);
255 if (is_tracing && base::TimeTicks::Now() > estimated_next_frame_begin_) {
256 TRACE_EVENT_ASYNC_STEP_INTO_WITH_TIMESTAMP0(
257 "renderer.scheduler",
258 "RendererSchedulerIdlePeriod",
259 this,
260 "DeadlineOverrun",
261 estimated_next_frame_begin_.ToInternalValue());
262 }
263 TRACE_EVENT_ASYNC_END0("renderer.scheduler", 253 TRACE_EVENT_ASYNC_END0("renderer.scheduler",
264 "RendererSchedulerIdlePeriod", this); 254 "RendererSchedulerIdlePeriod", this);
265 main_thread_checker_.CalledOnValidThread(); 255 main_thread_checker_.CalledOnValidThread();
266 end_idle_period_closure_.Cancel(); 256 end_idle_period_closure_.Cancel();
267 renderer_task_queue_selector_->DisableQueue(IDLE_TASK_QUEUE); 257 renderer_task_queue_selector_->DisableQueue(IDLE_TASK_QUEUE);
268 } 258 }
269 259
270 void RendererSchedulerImpl::SetTimeSourceForTesting( 260 void RendererSchedulerImpl::SetTimeSourceForTesting(
271 scoped_refptr<cc::TestNowSource> time_source) { 261 scoped_refptr<cc::TestNowSource> time_source) {
272 main_thread_checker_.CalledOnValidThread(); 262 main_thread_checker_.CalledOnValidThread();
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
343 state->SetDouble("last_input_time", 333 state->SetDouble("last_input_time",
344 (last_input_time_ - base::TimeTicks()).InMillisecondsF()); 334 (last_input_time_ - base::TimeTicks()).InMillisecondsF());
345 state->SetDouble( 335 state->SetDouble(
346 "estimated_next_frame_begin", 336 "estimated_next_frame_begin",
347 (estimated_next_frame_begin_ - base::TimeTicks()).InMillisecondsF()); 337 (estimated_next_frame_begin_ - base::TimeTicks()).InMillisecondsF());
348 338
349 return state; 339 return state;
350 } 340 }
351 341
352 } // namespace content 342 } // namespace content
OLDNEW
« no previous file with comments | « base/trace_event/trace_event.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698