Issue 916073004: Plugin Power Saver: Migrate ASK to BLOCK.

Issue 916073004: Plugin Power Saver: Migrate ASK to BLOCK. (Closed)

Created:
5 years, 10 months ago by tommycli

Modified:
5 years, 10 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews, dbeam+watch-options_chromium.org, markusheintz_, michaelpg+watch-options_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Plugin Power Saver: Migrate ASK to BLOCK. This changes the migration of ASK => DETECT to ASK => BLOCK. BUG=456248, 403800 Committed: https://crrev.com/986053c9c7f3c0e608b5854b4db33e8f31a204bb Cr-Commit-Position: refs/heads/master@{#316042}

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -12 lines)			Patch
M	chrome/browser/plugins/plugin_info_message_filter.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/website_settings/permission_menu_model.cc	View	2 chunks	+4 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/website_settings/website_settings_ui.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/options/content_settings_handler.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 7 (2 generated)

tommycli

thestig: Ptal (again, sorry) Launch review decided ASK => DETECT is a no go, and ...

5 years, 10 months ago (2015-02-12 19:08:58 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/916073004/1

5 years, 10 months ago (2015-02-12 19:59:26 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-12 20:22:18 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/986053c9c7f3c0e608b5854b4db33e8f31a204bb
Cr-Commit-Position: refs/heads/master@{#316042}