Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2615)

Unified Diff: chrome/browser/resources/pdf/navigator.js

Issue 915853004: Fix for PDFs with lots of named destinations take a long time to load. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/pdf/navigator.js
diff --git a/chrome/browser/resources/pdf/navigator.js b/chrome/browser/resources/pdf/navigator.js
index 57c15d4d26c47c983f83a839c766cb79d22f9dfe..4c492a87d07af5dc034f18c64ff6a4822e0be52d 100644
--- a/chrome/browser/resources/pdf/navigator.js
+++ b/chrome/browser/resources/pdf/navigator.js
@@ -74,12 +74,22 @@ Navigator.prototype = {
if (newTab) {
this.navigateInNewTabCallback_(url);
} else {
- var pageNumber =
- this.paramsParser_.getViewportFromUrlParams(url).page;
- if (pageNumber != undefined)
- this.viewport_.goToPage(pageNumber);
- else
- this.navigateInCurrentTabCallback_(url);
+ this.paramsParser_.getViewportFromUrlParams(url,
Sam McNally 2015/02/17 03:36:20 Wrap before url
raymes 2015/02/17 04:32:05 Done.
+ this.onViewportReceived_.bind(this));
}
+ },
+
+ /**
+ * @private
+ * Called when the viewport position is received.
+ * param {Object} viewportPosition Dictionary containing hte viewport
Sam McNally 2015/02/17 03:36:20 @param s/hte/the/
raymes 2015/02/17 04:32:04 Done.
+ * position.
+ */
+ onViewportReceived_: function(viewportPosition) {
+ var pageNumber = viewportPosition.page;
+ if (pageNumber != undefined)
+ this.viewport_.goToPage(pageNumber);
+ else
+ this.navigateInCurrentTabCallback_(url);
}
};

Powered by Google App Engine
This is Rietveld 408576698