Fix for PDFs with lots of named destinations take a long time to load.

Fix for PDFs with lots of named destinations take a long time to load.

When PDF have lots of named destinations then as we are fetching
all the named destinations at load time, so this will increase
loading time.
This is a workaround so that we will get named destination whenever
it is required by passing message from page to plugin.

BUG=457457
patch from issue 918953002 at patchset 80001 (http://crrev.com/918953002#ps80001)

[raymes, 2015-02-17 02:19:40]

raymes@chromium.org changed reviewers:
+ sammc@chromium.org

[Sam McNally, 2015-02-17 03:36:20]

https://codereview.chromium.org/915853004/diff/20001/chrome/browser/resources...
File chrome/browser/resources/pdf/navigator.js (right):

https://codereview.chromium.org/915853004/diff/20001/chrome/browser/resources...
chrome/browser/resources/pdf/navigator.js:77:
this.paramsParser_.getViewportFromUrlParams(url,
Wrap before url

https://codereview.chromium.org/915853004/diff/20001/chrome/browser/resources...
chrome/browser/resources/pdf/navigator.js:85: * param {Object} viewportPosition
Dictionary containing hte viewport
@param
s/hte/the/

https://codereview.chromium.org/915853004/diff/20001/chrome/browser/resources...
File chrome/browser/resources/pdf/open_pdf_params_parser.js (right):

https://codereview.chromium.org/915853004/diff/20001/chrome/browser/resources...
chrome/browser/resources/pdf/open_pdf_params_parser.js:71: //
explicitlymentioned except by example in the Adobe
Please add a space while you're here.

https://codereview.chromium.org/915853004/diff/20001/chrome/browser/resources...
chrome/browser/resources/pdf/open_pdf_params_parser.js:99: if ('nameddest' in
paramsDictionary) {
Can we skip this if a page or position is already specified?

https://codereview.chromium.org/915853004/diff/20001/chrome/browser/resources...
chrome/browser/resources/pdf/open_pdf_params_parser.js:118: if
(!outstandingRequest.viewportPosition.page && pageNumber != -1)
and remove the first condition here?

https://codereview.chromium.org/915853004/diff/20001/chrome/browser/resources...
File chrome/browser/resources/pdf/pdf.js (right):

https://codereview.chromium.org/915853004/diff/20001/chrome/browser/resources...
chrome/browser/resources/pdf/pdf.js:386: * important as later actions can
override the effects of previous actions.
@param

https://codereview.chromium.org/915853004/diff/20001/pdf/out_of_process_insta...
File pdf/out_of_process_instance.cc (right):

https://codereview.chromium.org/915853004/diff/20001/pdf/out_of_process_insta...
pdf/out_of_process_instance.cc:148: const char kJSNamedDestinationPageNumber[] =
"namedDestinationPageNumber";
How about pageNumber?

[raymes, 2015-02-17 04:32:05]

https://codereview.chromium.org/915853004/diff/20001/chrome/browser/resources...
File chrome/browser/resources/pdf/navigator.js (right):

https://codereview.chromium.org/915853004/diff/20001/chrome/browser/resources...
chrome/browser/resources/pdf/navigator.js:77:
this.paramsParser_.getViewportFromUrlParams(url,
On 2015/02/17 03:36:20, Sam McNally wrote:
> Wrap before url

Done.

https://codereview.chromium.org/915853004/diff/20001/chrome/browser/resources...
chrome/browser/resources/pdf/navigator.js:85: * param {Object} viewportPosition
Dictionary containing hte viewport
On 2015/02/17 03:36:20, Sam McNally wrote:
> @param
> s/hte/the/

Done.

https://codereview.chromium.org/915853004/diff/20001/chrome/browser/resources...
File chrome/browser/resources/pdf/open_pdf_params_parser.js (right):

https://codereview.chromium.org/915853004/diff/20001/chrome/browser/resources...
chrome/browser/resources/pdf/open_pdf_params_parser.js:71: //
explicitlymentioned except by example in the Adobe
On 2015/02/17 03:36:20, Sam McNally wrote:
> Please add a space while you're here.

Done.

https://codereview.chromium.org/915853004/diff/20001/chrome/browser/resources...
chrome/browser/resources/pdf/open_pdf_params_parser.js:99: if ('nameddest' in
paramsDictionary) {
On 2015/02/17 03:36:20, Sam McNally wrote:
> Can we skip this if a page or position is already specified?

Done.

https://codereview.chromium.org/915853004/diff/20001/chrome/browser/resources...
chrome/browser/resources/pdf/open_pdf_params_parser.js:118: if
(!outstandingRequest.viewportPosition.page && pageNumber != -1)
On 2015/02/17 03:36:20, Sam McNally wrote:
> and remove the first condition here?

Done.

https://codereview.chromium.org/915853004/diff/20001/chrome/browser/resources...
File chrome/browser/resources/pdf/pdf.js (right):

https://codereview.chromium.org/915853004/diff/20001/chrome/browser/resources...
chrome/browser/resources/pdf/pdf.js:386: * important as later actions can
override the effects of previous actions.
On 2015/02/17 03:36:20, Sam McNally wrote:
> @param

Done.

https://codereview.chromium.org/915853004/diff/20001/pdf/out_of_process_insta...
File pdf/out_of_process_instance.cc (right):

https://codereview.chromium.org/915853004/diff/20001/pdf/out_of_process_insta...
pdf/out_of_process_instance.cc:148: const char kJSNamedDestinationPageNumber[] =
"namedDestinationPageNumber";
On 2015/02/17 03:36:20, Sam McNally wrote:
> How about pageNumber?

Done.

[Sam McNally, 2015-02-17 05:55:38]

LGTM

https://codereview.chromium.org/915853004/diff/40001/chrome/test/data/pdf/par...
File chrome/test/data/pdf/params_parser_test.js (right):

https://codereview.chromium.org/915853004/diff/40001/chrome/test/data/pdf/par...
chrome/test/data/pdf/params_parser_test.js:59:
chrome.test.assertEq(viewportPosition.position, 22);
s/position/page/

[Deepak, 2015-02-17 09:10:39]

On 2015/02/17 05:55:38, Sam McNally wrote:
> LGTM
> 
>
https://codereview.chromium.org/915853004/diff/40001/chrome/test/data/pdf/par...
> File chrome/test/data/pdf/params_parser_test.js (right):
> 
>
https://codereview.chromium.org/915853004/diff/40001/chrome/test/data/pdf/par...
> chrome/test/data/pdf/params_parser_test.js:59:
> chrome.test.assertEq(viewportPosition.position, 22);
> s/position/page/

@sam 
As per raymes 
I have updated all changes at https://codereview.chromium.org/918953002/.
PTAL at that patch.