Issue 915573002: debugger: Abandon context when Qt changes it without notice

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 915573002: debugger: Abandon context when Qt changes it without notice (Closed)

Created:
5 years, 10 months ago by Kimmo Kinnunen

Modified:
5 years, 10 months ago

Reviewers:
bsalomon

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

debugger: Abandon context when Qt changes it without notice Qt changes the context on many conditions. Abandon GrContext in these cases. Also call GrContext::resetContext during Qt GL paint callback, the GL state may be touched by Qt. Fixes the bug where changing between gpu and msaa would start erroring in framebuffer binds, if the .skp had many layers. Committed: https://skia.googlesource.com/skia/+/9e33d1dbccee9b13ac001dfc3094a503f9e84e9d

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -9 lines)			Patch
	M	debugger/QT/SkGLWidget.cpp	View		2 chunks	+7 lines, -9 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/915573002/1

5 years, 10 months ago (2015-02-11 06:21:34 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-11 06:27:52 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/9e33d1dbccee9b13ac001dfc3094a503f9e84e9d

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages