Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 915303002: [Telemtry] Move url lists of alexa1-10000 page to a json file. (Closed)

Created:
5 years, 10 months ago by nednguyen
Modified:
4 years, 5 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemtry] Move url lists of alexa1-10000 page to a json file. Existing implementation of alexa1-10000 embeds the huge url list in the python file, which is a terrible. It makes it super hard to navigate through the file, or review its content, and make it harder to update the alexa1-10000 pages if needed. Committed: https://crrev.com/fec4b0793f9d7eb6bef66f83687f10e6391dff62 Cr-Commit-Position: refs/heads/master@{#316012}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+9689 lines, -19348 lines) Patch
M tools/perf/page_sets/alexa1-10000.py View 2 chunks +13 lines, -19347 lines 0 comments Download
A tools/perf/page_sets/alexa1-10000-urls.json View 1 chunk +9675 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 11 (3 generated)
nednguyen
https://codereview.chromium.org/915303002/diff/1/tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py File tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py (right): https://codereview.chromium.org/915303002/diff/1/tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py#newcode106 tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py:106: isinstance(page.url, basestring), @Reviewers: this change is needed because urls ...
5 years, 10 months ago (2015-02-12 04:36:46 UTC) #2
sullivan
lgtm Thanks for the cleanup! https://codereview.chromium.org/915303002/diff/1/tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py File tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py (right): https://codereview.chromium.org/915303002/diff/1/tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py#newcode106 tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py:106: isinstance(page.url, basestring), On 2015/02/12 ...
5 years, 10 months ago (2015-02-12 15:20:51 UTC) #3
nednguyen
On 2015/02/12 15:20:51, sullivan wrote: > lgtm > > Thanks for the cleanup! > > ...
5 years, 10 months ago (2015-02-12 16:42:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/915303002/1
5 years, 10 months ago (2015-02-12 16:42:41 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-12 18:47:30 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fec4b0793f9d7eb6bef66f83687f10e6391dff62 Cr-Commit-Position: refs/heads/master@{#316012}
5 years, 10 months ago (2015-02-12 18:48:27 UTC) #8
rpaquay
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/920953003/ by rpaquay@chromium.org. ...
5 years, 10 months ago (2015-02-12 21:19:44 UTC) #9
ericwalters9967
4 years, 5 months ago (2016-07-07 16:42:58 UTC) #11
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698