Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 915213002: :visited invalidation for background/border/outline. (Closed)

Created:
5 years, 10 months ago by rune
Modified:
5 years, 10 months ago
Reviewers:
Xianzhu
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

:visited invalidation for background/border/outline. Following up https://codereview.chromium.org/900443006 Repaint backgrounds, borders, and outlines when their :visited colors change. R=wangxianzhu@chromium.org BUG=439812 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190027

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -1 line) Patch
A LayoutTests/fast/history/visited-link-hover-background-color.html View 1 chunk +21 lines, -0 lines 1 comment Download
A LayoutTests/fast/history/visited-link-hover-background-color-expected.html View 1 chunk +2 lines, -0 lines 0 comments Download
A LayoutTests/fast/history/visited-link-hover-border-color.html View 1 chunk +21 lines, -0 lines 0 comments Download
A LayoutTests/fast/history/visited-link-hover-border-color-expected.html View 1 chunk +2 lines, -0 lines 0 comments Download
A LayoutTests/fast/history/visited-link-hover-outline-color.html View 1 chunk +21 lines, -0 lines 0 comments Download
A LayoutTests/fast/history/visited-link-hover-outline-color-expected.html View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/layout/style/LayoutStyle.cpp View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
rune
Hopefully last :visited invalidation CL ...
5 years, 10 months ago (2015-02-12 00:03:19 UTC) #1
Xianzhu
lgtm with a question https://codereview.chromium.org/915213002/diff/1/LayoutTests/fast/history/visited-link-hover-background-color.html File LayoutTests/fast/history/visited-link-hover-background-color.html (right): https://codereview.chromium.org/915213002/diff/1/LayoutTests/fast/history/visited-link-hover-background-color.html#newcode4 LayoutTests/fast/history/visited-link-hover-background-color.html:4: testRunner.keepWebHistory(); What's this for?
5 years, 10 months ago (2015-02-12 00:48:32 UTC) #2
rune
On 2015/02/12 at 00:48:32, wangxianzhu wrote: > lgtm with a question > > https://codereview.chromium.org/915213002/diff/1/LayoutTests/fast/history/visited-link-hover-background-color.html > ...
5 years, 10 months ago (2015-02-12 06:57:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/915213002/1
5 years, 10 months ago (2015-02-12 06:58:28 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 07:02:15 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190027

Powered by Google App Engine
This is Rietveld 408576698