tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend_list.py - Issue 915173012: telemetry: Add a method to access tabs by key in TabList.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend_list.py

Issue 915173012: telemetry: Add a method to access tabs by key in TabList. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add comment. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py ('k') | tools/telemetry/telemetry/core/tab_list.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend_list.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend_list.py b/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend_list.py

index 1b918507c9cb3b23155b024c3baff9b75ff23aea..ea3a6e2f55fb31fc153c98ebc7e5f71652084279 100644

--- a/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend_list.py

+++ b/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend_list.py

@@ -67,6 +67,10 @@ class InspectorBackendList(collections.Sequence):

context_id = self._filtered_context_ids[index]

return self.GetBackendFromContextId(context_id)

+ def GetTabById(self, identifier):

+ self._Update()

+ return self.GetBackendFromContextId(identifier)

def GetBackendFromContextId(self, context_id):

self._Update()

if context_id not in self._wrapper_dict: