tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py - Issue 915173012: telemetry: Add a method to access tabs by key in TabList.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py

Issue 915173012: telemetry: Add a method to access tabs by key in TabList. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add comment. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py b/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py

index 338f13a8eecfd4a4983b4f79b668a6dfdd20cb06..69f6a1851439c0313a12f7c42f968a1d2e5cb02b 100644

--- a/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py

+++ b/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py

@@ -71,11 +71,9 @@ class InspectorBackend(object):

return c['url']

return None

- # TODO(chrishenry): Is this intentional? Shouldn't this return

- # self._context['id'] instead?

@property

def id(self):

- return self.debugger_url

+ return self._context['id']

@property

def debugger_url(self):

« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend_list.py » ('j') | no next file with comments »