Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 915133002: Revert of HID-detection screen moved to screenContext. (Closed)

Created:
5 years, 10 months ago by dewittj
Modified:
5 years, 10 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, dzhioev+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of HID-detection screen moved to screenContext. (patchset #7 id:120001 of https://codereview.chromium.org/898453002/) Reason for revert: I believe this is causing interactive_ui_tests failures: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29 LoginUITest.OobeCatchException LoginUITest.OobeNoExceptions LoginUITest.OobeCatchException (run #4): [ RUN ] LoginUITest.OobeCatchException [1:1:0211/103529:ERROR:memory_mapped_file.cc(42)] Couldn't open /tmp/run_tha_testo_ZzaC/out/Debug/chrome_200_percent.pak [1:1:0211/103529:ERROR:data_pack.cc(78)] Failed to mmap datapack [31306:31306:0211/103529:INFO:audio_manager_pulse.cc(258)] Failed to connect to the context. Error: Connection refused [31306:31306:0211/103529:ERROR:memory_mapped_file.cc(42)] Couldn't open /tmp/run_tha_testo_ZzaC/out/Debug/chrome_200_percent.pak [31306:31306:0211/103529:ERROR:data_pack.cc(78)] Failed to mmap datapack Xlib: extension "RANDR" missing on display ":9". [31306:31306:0211/103529:WARNING:child_account_service.cc(322)] User instance wasn't found while setting child account flag. [31306:31306:0211/103529:WARNING:data_reduction_proxy_settings.cc(366)] SPDY proxy OFF at startup [31306:31306:0211/103529:ERROR:hid_detection_screen_handler.cc(35)] HIDDetectionScreenHandler::HIDDetectionScreenHandler [31306:31306:0211/103529:ERROR:hid_detection_screen_handler.cc(79)] HIDDetectionScreenHandler::CheckIsScreenRequired 0x325bf0183920 [31306:31324:0211/103529:WARNING:freezer_cgroup_process_manager.cc(58)] Cgroup freezer does not exist or is not writable. Unable to freeze renderer processes. ../../chrome/browser/chromeos/login/test/js_checker.cc:62: Failure Value of: GetBool(expression) Actual: false Expected: true cr.ErrorStore.getInstance().length == 0 ../../chrome/browser/chromeos/login/test/js_checker.cc:62: Failure Value of: GetBool(expression) Actual: false Expected: true cr.ErrorStore.getInstance().length == 1 ../../chrome/browser/chromeos/login/test/js_checker.cc:62: Failure Value of: GetBool(expression) Actual: false Expected: true cr.ErrorStore.getInstance().length == 2 [7:8:0211/103533:WARNING:channel.cc(547)] Failed to send message to ack remove remote endpoint (local ID 1, remote ID 1) [7:8:0211/103533:WARNING:channel.cc(547)] Failed to send message to ack remove remote endpoint (local ID 2147483648, remote ID 2) [ FAILED ] LoginUITest.OobeCatchException, where TypeParam = and GetParam() = (4704 ms) Original issue's description: > HID-detection screen moved to screenContext. > > BUG=433797 > > Committed: https://crrev.com/cc4feaa0828ee6d58c6a3eecf67e9d6bf72588a7 > Cr-Commit-Position: refs/heads/master@{#315788} TBR=antrim@chromium.org,merkulova@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=433797 Committed: https://crrev.com/2ad7324324f1a52d37fb0ed9de39559c7d431082 Cr-Commit-Position: refs/heads/master@{#315804}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+806 lines, -992 lines) Patch
D chrome/browser/chromeos/login/screens/hid_detection_model.h View 1 chunk +0 lines, -49 lines 0 comments Download
D chrome/browser/chromeos/login/screens/hid_detection_model.cc View 1 chunk +0 lines, -38 lines 0 comments Download
M chrome/browser/chromeos/login/screens/hid_detection_screen.h View 1 chunk +10 lines, -183 lines 0 comments Download
M chrome/browser/chromeos/login/screens/hid_detection_screen.cc View 1 chunk +17 lines, -515 lines 0 comments Download
A chrome/browser/chromeos/login/screens/hid_detection_screen_actor.h View 1 chunk +46 lines, -0 lines 0 comments Download
D chrome/browser/chromeos/login/screens/hid_detection_view.h View 1 chunk +0 lines, -36 lines 0 comments Download
M chrome/browser/chromeos/login/ui/oobe_display.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.h View 5 chunks +4 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 4 chunks +5 lines, -8 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_hid_detection.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_hid_detection.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_hid_detection.js View 6 chunks +47 lines, -103 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/hid_detection_screen_handler.h View 2 chunks +168 lines, -10 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/hid_detection_screen_handler.cc View 6 chunks +498 lines, -29 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dewittj
Created Revert of HID-detection screen moved to screenContext.
5 years, 10 months ago (2015-02-11 19:10:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/915133002/1
5 years, 10 months ago (2015-02-11 19:12:12 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-11 19:13:20 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-11 19:14:22 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2ad7324324f1a52d37fb0ed9de39559c7d431082
Cr-Commit-Position: refs/heads/master@{#315804}

Powered by Google App Engine
This is Rietveld 408576698