Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 915103002: interpret conic tolerance correctly -- big rebaseline (Closed)

Created:
5 years, 10 months ago by reed1
Modified:
5 years, 10 months ago
CC:
reviews_skia.org, reed2
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

interpret conic tolerance correctly -- big rebaseline need this to land in chrome https://codereview.chromium.org/918233002/ NOTREECHECKS=True Committed: https://skia.googlesource.com/skia/+/f16c00e41b72daa81ed7efacbead06b387767841

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : impl float version, but it seems more complex #

Patch Set 4 : #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -0 lines) Patch
M src/core/SkGeometry.cpp View 1 2 2 chunks +37 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
reed1
This is a giant rebaseliner -- ~75 different GMs are affected. A few places improved, ...
5 years, 10 months ago (2015-02-11 18:54:50 UTC) #2
_cary
lgtm
5 years, 10 months ago (2015-02-11 19:12:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/915103002/20001
5 years, 10 months ago (2015-02-11 19:16:36 UTC) #6
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-02-11 19:16:37 UTC) #7
robertphillips
lgtm https://codereview.chromium.org/915103002/diff/20001/src/core/SkGeometry.cpp File src/core/SkGeometry.cpp (right): https://codereview.chromium.org/915103002/diff/20001/src/core/SkGeometry.cpp#newcode1441 src/core/SkGeometry.cpp:1441: suggested?
5 years, 10 months ago (2015-02-11 20:01:09 UTC) #9
robertphillips
https://codereview.chromium.org/915103002/diff/20001/src/core/SkGeometry.cpp File src/core/SkGeometry.cpp (right): https://codereview.chromium.org/915103002/diff/20001/src/core/SkGeometry.cpp#newcode1451 src/core/SkGeometry.cpp:1451: Don't you want to put this in a gypi ...
5 years, 10 months ago (2015-02-11 20:01:54 UTC) #10
reed1
On 2015/02/11 20:01:54, robertphillips wrote: > https://codereview.chromium.org/915103002/diff/20001/src/core/SkGeometry.cpp > File src/core/SkGeometry.cpp (right): > > https://codereview.chromium.org/915103002/diff/20001/src/core/SkGeometry.cpp#newcode1451 > ...
5 years, 10 months ago (2015-02-12 15:59:15 UTC) #12
reed1
5 years, 10 months ago (2015-02-12 20:24:40 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/915103002/80001
5 years, 10 months ago (2015-02-13 01:47:25 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/915103002/80001
5 years, 10 months ago (2015-02-13 01:56:16 UTC) #18
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 01:56:24 UTC) #19
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/f16c00e41b72daa81ed7efacbead06b387767841

Powered by Google App Engine
This is Rietveld 408576698