interpret conic tolerance correctly -- big rebaseline

src/core/SkGeometry.cpp

 /*
  * Copyright 2006 The Android Open Source Project
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkGeometry.h"
 #include "SkMatrix.h"
 
@@ skipping 1420 matching lines @@
 
 void SkConic::computeAsQuadError(SkVector* err) const {
     AS_QUAD_ERROR_SETUP
     err->set(x, y);
 }
 
 bool SkConic::asQuadTol(SkScalar tol) const {
     AS_QUAD_ERROR_SETUP
     return (x * x + y * y) <= tol * tol;
 }
 

[robertphillips, 2015/02/11 20:01:09]

suggested?

+// Limit the number of suggested quads to approximate a conic
+#define kMaxConicToQuadPOW2 4
+
 int SkConic::computeQuadPOW2(SkScalar tol) const {
+    if (tol < 0 || !SkScalarIsFinite(tol)) {
+        return 0;
+    }
+
     AS_QUAD_ERROR_SETUP
+

[robertphillips, 2015/02/11 20:01:54]

Don't you want to put this in a gypi somewhere?

+#ifdef SK_SUPPORT_LEGACY_CONIC_COMPUTE_QUAD_POW2
     SkScalar error = SkScalarSqrt(x * x + y * y) - tol;
 
     if (error <= 0) {
         return 0;
     }
     uint32_t ierr = (uint32_t)error;
     return (34 - SkCLZ(ierr)) >> 1;
+#else
+    SkScalar error = SkScalarSqrt(x * x + y * y);
+    int pow2;
+    for (pow2 = 0; pow2 < kMaxConicToQuadPOW2; ++pow2) {
+        if (error <= tol) {
+            break;
+        }
+        error *= 0.25f;
+    }
+    return pow2;
+#endif
 }
 
 static SkPoint* subdivide(const SkConic& src, SkPoint pts[], int level) {
     SkASSERT(level >= 0);
 
     if (0 == level) {
         memcpy(pts, &src.fPts[1], 2 * sizeof(SkPoint));
         return pts + 2;
     } else {
         SkConic dst[2];
@@ skipping 173 matching lines @@
         matrix.preScale(SK_Scalar1, -SK_Scalar1);
     }
     if (userMatrix) {
         matrix.postConcat(*userMatrix);
     }
     for (int i = 0; i < conicCount; ++i) {
         matrix.mapPoints(dst[i].fPts, 3);
     }
     return conicCount;
 }