Issue 9149008: Fixes for parsing warnigs, issue 1060.

Issue 9149008: Fixes for parsing warnigs, issue 1060. (Closed)

Created:
8 years, 11 months ago by scheglov

Modified:
8 years, 11 months ago

Reviewers:
sra1, zundel

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fixes for parsing warnigs, issue 1060. 1. Diet parsing notification fix. 2. Disable name shadow warnings for htmlimpl.dart library, until library itself will be fixed. 3. Fix for identifying core libraries in Editor. R=zundel@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=3113

Patch Set 1 #

Total comments: 2

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -32 lines)			Patch
M	compiler/java/com/google/dart/compiler/ast/DartUnit.java	View	2 chunks	+3 lines, -9 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/ast/LibraryUnit.java	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/parser/DartParser.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/Elements.java	View	2 chunks	+17 lines, -0 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java	View	1 chunk	+5 lines, -1 line	2 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/SupertypeResolver.java	View	2 chunks	+2 lines, -12 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/resolver/ResolverTestCase.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/AST.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/DartModelManagerTest.java	View	5 chunks	+7 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sra1

8 years, 11 months ago (2012-01-09 22:02:24 UTC) #3

http://codereview.chromium.org/9149008/diff/1/compiler/java/com/google/dart/c...
File compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java
(right):

http://codereview.chromium.org/9149008/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java:84: if
(!Elements.isLibrarySource(element.getNode().getSource(), "htmlimpl.dart")) {
Does this suppress only the shadowing warnings?
Mostly they are 'parameter' or 'local' shadows 'method'

http://codereview.chromium.org/9149008/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java:84: if
(!Elements.isLibrarySource(element.getNode().getSource(), "htmlimpl.dart")) {
dart:dom has exactly the same issue.
Please treat dart:dom and dart:htmlimpl the same with regards to this issue.

Expand Messages | Collapse Messages