Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java

Issue 9149008: Fixes for parsing warnigs, issue 1060. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java
diff --git a/compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java b/compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java
index b431b7c60af0334e9340d0a328995e01ecee5a5c..867798f2da9473b967fc0f40640300aefdda2aed 100644
--- a/compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java
+++ b/compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java
@@ -79,7 +79,11 @@ public class ResolutionContext implements ResolutionErrorListener {
&& !existingElement.getModifiers().isAbstractField()) {
DartNode nameNode = Elements.getNameNode(element);
String existingLocation = Elements.getRelativeElementLocation(element, existingElement);
- onError(nameNode, warningCode, name, existingElement, existingLocation);
+ // TODO(scheglov) remove condition once HTML will be fixed to don't have duplicates.
+ // http://code.google.com/p/dart/issues/detail?id=1060
+ if (!Elements.isLibrarySource(element.getNode().getSource(), "htmlimpl.dart")) {
sra1 2012/01/09 22:02:24 Does this suppress only the shadowing warnings? Mo
sra1 2012/01/09 22:02:24 dart:dom has exactly the same issue. Please treat
+ onError(nameNode, warningCode, name, existingElement, existingLocation);
+ }
}
}
}

Powered by Google App Engine
This is Rietveld 408576698