components/gcm_driver/gcm_driver_desktop.cc - Issue 914693002: Push API: Fix unsubscribing from GCM on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/gcm_driver/gcm_driver_desktop.cc

Issue 914693002: Push API: Fix unsubscribing from GCM on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comment nits I missed earlier Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/gcm_driver/gcm_driver_desktop.cc

diff --git a/components/gcm_driver/gcm_driver_desktop.cc b/components/gcm_driver/gcm_driver_desktop.cc

index 6a9153986819f84471c5c6d49f7df3d8c5201986..812b0d3fcbc7e8da6399493591739dc70afeae8f 100644

--- a/components/gcm_driver/gcm_driver_desktop.cc

+++ b/components/gcm_driver/gcm_driver_desktop.cc

@@ -522,7 +522,8 @@ void GCMDriverDesktop::DoRegister(const std::string& app_id,

sender_ids));

}

-void GCMDriverDesktop::UnregisterImpl(const std::string& app_id) {

+void GCMDriverDesktop::UnregisterImpl(

+ const std::string& app_id, const std::vector<std::string>& /*sender_ids*/) {

// Delay the unregister operation until GCMClient is ready.

if (!delayed_task_controller_->CanRunTaskWithoutDelay()) {

delayed_task_controller_->AddTask(