Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 914523002: Initialize WindowProxy for RemoteFrames. (Closed)

Created:
5 years, 10 months ago by dcheng
Modified:
5 years, 10 months ago
Reviewers:
haraken
CC:
blink-reviews, Nate Chapin, site-isolation-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Initialize WindowProxy for RemoteFrames. Without this, frame.contentWindow will always be null. BUG=425623 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189925

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add assert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M Source/core/frame/RemoteFrame.cpp View 1 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
dcheng
I didn't make this return WindowProxy& by reference--I think we still have the issue where ...
5 years, 10 months ago (2015-02-10 00:51:04 UTC) #2
haraken
LGTM https://codereview.chromium.org/914523002/diff/1/Source/core/frame/RemoteFrame.cpp File Source/core/frame/RemoteFrame.cpp (right): https://codereview.chromium.org/914523002/diff/1/Source/core/frame/RemoteFrame.cpp#newcode52 Source/core/frame/RemoteFrame.cpp:52: WindowProxy* windowProxy = m_windowProxyManager->windowProxy(world); Shall we add ASSERT(windowProxy) ...
5 years, 10 months ago (2015-02-10 01:10:51 UTC) #3
dcheng
https://codereview.chromium.org/914523002/diff/1/Source/core/frame/RemoteFrame.cpp File Source/core/frame/RemoteFrame.cpp (right): https://codereview.chromium.org/914523002/diff/1/Source/core/frame/RemoteFrame.cpp#newcode52 Source/core/frame/RemoteFrame.cpp:52: WindowProxy* windowProxy = m_windowProxyManager->windowProxy(world); On 2015/02/10 01:10:51, haraken wrote: ...
5 years, 10 months ago (2015-02-10 18:57:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/914523002/20001
5 years, 10 months ago (2015-02-10 18:58:54 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-10 20:20:50 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189925

Powered by Google App Engine
This is Rietveld 408576698