Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 914413004: Add a new bindings2/scripts directory for Dart bindings (Closed)

Created:
5 years, 10 months ago by eseidel
Modified:
5 years, 10 months ago
Reviewers:
jamesr, abarth-chromium
CC:
abarth-chromium, Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add a new bindings2/scripts directory for Dart bindings These bindings were developed over the last 2 weeks on: https://github.com/eseidel/skydart They started as copies of the Dartium scripts (aka dart/tools/dom): https://code.google.com/p/dart/source/browse/#svn%2Ftrunk%2Fdart%2Ftools%2Fdom Which in turn started as a forked copy of Blink's binding generation scripts from some years ago. This is still way more python than we need to generate bindings for SkyDart, but it's a start. Reviews were done for many (but not all) of the patches. I'll add the bindings2/ code and build system wiring in further patches. Landing the new directories one at a time so that it's easier to read through. R=abarth@chromium.org, jamesr@chromium.org BUG=454613 Committed: https://chromium.googlesource.com/external/mojo/+/eb926e70c355f19b418e3ac0e71b4778afbf116e

Patch Set 1 #

Patch Set 2 : Only do scripts in this CL #

Patch Set 3 : Remove idlrenderer.py it's not used #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5269 lines, -780 lines) Patch
A + sky/engine/bindings2/scripts/blink_idl_lexer.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/engine/bindings2/scripts/blink_idl_parser.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A sky/engine/bindings2/scripts/code_generator_dart.py View 1 chunk +280 lines, -0 lines 0 comments Download
A sky/engine/bindings2/scripts/compiler.py View 1 chunk +142 lines, -0 lines 0 comments Download
A + sky/engine/bindings2/scripts/compute_interfaces_info_individual.py View 2 chunks +1 line, -2 lines 0 comments Download
A + sky/engine/bindings2/scripts/compute_interfaces_info_overall.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A sky/engine/bindings2/scripts/dart_attributes.py View 1 chunk +274 lines, -0 lines 0 comments Download
A + sky/engine/bindings2/scripts/dart_callback_interface.py View 4 chunks +39 lines, -40 lines 0 comments Download
A sky/engine/bindings2/scripts/dart_compiler.py View 1 chunk +103 lines, -0 lines 0 comments Download
A sky/engine/bindings2/scripts/dart_interface.py View 1 chunk +741 lines, -0 lines 0 comments Download
A sky/engine/bindings2/scripts/dart_methods.py View 1 chunk +245 lines, -0 lines 0 comments Download
A sky/engine/bindings2/scripts/dart_types.py View 1 chunk +874 lines, -0 lines 0 comments Download
A sky/engine/bindings2/scripts/dart_utilities.py View 1 chunk +135 lines, -0 lines 0 comments Download
A + sky/engine/bindings2/scripts/generate_event_interfaces.py View 2 chunks +0 lines, -4 lines 0 comments Download
A + sky/engine/bindings2/scripts/idl_definitions.py View 2 chunks +0 lines, -48 lines 0 comments Download
A + sky/engine/bindings2/scripts/idl_reader.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/engine/bindings2/scripts/idl_types.py View 3 chunks +1 line, -6 lines 0 comments Download
A + sky/engine/bindings2/scripts/idl_validator.py View 1 chunk +1 line, -1 line 0 comments Download
A sky/engine/bindings2/scripts/idlnode.py View 1 chunk +814 lines, -0 lines 0 comments Download
A + sky/engine/bindings2/scripts/interface_dependency_resolver.py View 1 chunk +0 lines, -2 lines 0 comments Download
A sky/engine/bindings2/scripts/templates/attributes_cpp.template View 1 chunk +204 lines, -0 lines 0 comments Download
A sky/engine/bindings2/scripts/templates/callback_interface_cpp.template View 1 chunk +49 lines, -0 lines 0 comments Download
A + sky/engine/bindings2/scripts/templates/callback_interface_dart.template View 1 chunk +3 lines, -4 lines 0 comments Download
A sky/engine/bindings2/scripts/templates/callback_interface_h.template View 1 chunk +77 lines, -0 lines 0 comments Download
A sky/engine/bindings2/scripts/templates/dart_blink.template View 1 chunk +21 lines, -0 lines 0 comments Download
A sky/engine/bindings2/scripts/templates/global_cpp.template View 1 chunk +38 lines, -0 lines 0 comments Download
A sky/engine/bindings2/scripts/templates/global_h.template View 1 chunk +19 lines, -0 lines 0 comments Download
A sky/engine/bindings2/scripts/templates/interface_base_cpp.template View 1 chunk +145 lines, -0 lines 0 comments Download
A sky/engine/bindings2/scripts/templates/interface_cpp.template View 1 chunk +160 lines, -0 lines 0 comments Download
A sky/engine/bindings2/scripts/templates/interface_dart.template View 1 chunk +43 lines, -0 lines 0 comments Download
A sky/engine/bindings2/scripts/templates/interface_h.template View 1 chunk +60 lines, -0 lines 0 comments Download
A sky/engine/bindings2/scripts/templates/methods_cpp.template View 1 chunk +406 lines, -0 lines 0 comments Download
A + sky/engine/bindings2/scripts/utilities.py View 2 chunks +0 lines, -20 lines 0 comments Download
A + sky/engine/bindings2/scripts/v8_attributes.py View 13 chunks +2 lines, -179 lines 0 comments Download
A + sky/engine/bindings2/scripts/v8_globals.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/engine/bindings2/scripts/v8_interface.py View 18 chunks +10 lines, -256 lines 0 comments Download
A + sky/engine/bindings2/scripts/v8_methods.py View 19 chunks +1 line, -135 lines 0 comments Download
A sky/engine/bindings2/scripts/v8_types.py View 1 chunk +386 lines, -0 lines 0 comments Download
A + sky/engine/bindings2/scripts/v8_utilities.py View 5 chunks +0 lines, -88 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
abarth-chromium
LGTM Please file a bug about improving these scripts to have less V8 and Dartium ...
5 years, 10 months ago (2015-02-12 20:22:22 UTC) #1
eseidel
5 years, 10 months ago (2015-02-12 20:22:42 UTC) #2
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
eb926e70c355f19b418e3ac0e71b4778afbf116e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698