Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: sky/engine/bindings2/scripts/idl_types.py

Issue 914413004: Add a new bindings2/scripts directory for Dart bindings (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Remove idlrenderer.py it's not used Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/bindings2/scripts/idl_reader.py ('k') | sky/engine/bindings2/scripts/idl_validator.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/bindings2/scripts/idl_types.py
diff --git a/sky/engine/bindings/scripts/idl_types.py b/sky/engine/bindings2/scripts/idl_types.py
similarity index 98%
copy from sky/engine/bindings/scripts/idl_types.py
copy to sky/engine/bindings2/scripts/idl_types.py
index 1b22eb6772ce83ce789a28946923bffb917392f7..ffdae966356d57fff47555bcdf1eb9934b6a80f3 100644
--- a/sky/engine/bindings/scripts/idl_types.py
+++ b/sky/engine/bindings2/scripts/idl_types.py
@@ -153,10 +153,6 @@ class IdlType(IdlTypeBase):
return self.base_type in IdlType.callback_interfaces
@property
- def is_dictionary(self):
- return self.base_type in IdlType.dictionaries
-
- @property
def is_enum(self):
# FIXME: add an IdlEnumType class and a resolve_enums step at end of
# IdlDefinitions constructor
@@ -186,7 +182,6 @@ class IdlType(IdlTypeBase):
# In C++ these are RefPtr or PassRefPtr types.
return not(self.is_basic_type or
self.is_callback_function or
- self.is_dictionary or
self.is_enum or
self.name == 'Any' or
self.name == 'Object' or
@@ -331,7 +326,7 @@ class IdlNullableType(IdlTypeBase):
@property
def name(self):
- return self.inner_type.name + 'OrNull'
+ return self.inner_type.name
def resolve_typedefs(self, typedefs):
self.inner_type = self.inner_type.resolve_typedefs(typedefs)
« no previous file with comments | « sky/engine/bindings2/scripts/idl_reader.py ('k') | sky/engine/bindings2/scripts/idl_validator.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698