content/browser/android/content_startup_flags.cc - Issue 914373003: Exceptions for Web Notifications and the Push API by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/content_startup_flags.cc

Issue 914373003: Exceptions for Web Notifications and the Push API by default. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix the AndroidWebViewTest assert Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/services/gcm/push_messaging_service_impl.cc ('k') | content/browser/renderer_host/render_process_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/android/content_startup_flags.cc

diff --git a/content/browser/android/content_startup_flags.cc b/content/browser/android/content_startup_flags.cc

index 9254c28e1aa722c3e971e8ea354e88890a3d9ce2..e5acab948e7afdab20e5bc6b3ea37e7399099955 100644

--- a/content/browser/android/content_startup_flags.cc

+++ b/content/browser/android/content_startup_flags.cc

@@ -4,6 +4,7 @@

#include "content/browser/android/content_startup_flags.h"

+#include "base/android/build_info.h"

#include "base/base_switches.h"

#include "base/command_line.h"

#include "base/logging.h"

@@ -70,6 +71,12 @@ void SetContentCommandLineFlags(bool single_process,

if (base::SysInfo::IsLowEndDevice())

parsed_command_line->AppendSwitch(switches::kInProcessGPU);

+ // Web Notifications are only supported on Android JellyBean and beyond.

+ if (base::android::BuildInfo::GetInstance()->sdk_int() <

+ base::android::SDK_VERSION_JELLY_BEAN) {

+ parsed_command_line->AppendSwitch(switches::kDisableNotifications);

+ }

parsed_command_line->AppendSwitch(switches::kEnableViewportMeta);

parsed_command_line->AppendSwitch(

switches::kMainFrameResizesAreOrientationChanges);