components/signin/core/browser/signin_metrics.cc - Issue 914363003: Remove OneClickSigninHelper since it is no longer used.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/signin/core/browser/signin_metrics.cc

Issue 914363003: Remove OneClickSigninHelper since it is no longer used. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ocl

Patch Set: rebased Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/signin/inline_login_handler_impl.cc ('K') | « components/signin/core/browser/signin_metrics.h ('k') | tools/perf/page_sets/tough_energy_cases.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/signin/core/browser/signin_metrics.cc

diff --git a/components/signin/core/browser/signin_metrics.cc b/components/signin/core/browser/signin_metrics.cc

index 4f7c4793a0b6f773d7ccbf2941b57c93d570b03e..4a2ea6bf809967496a52c673f63b1b87507bbf76 100644

--- a/components/signin/core/browser/signin_metrics.cc

+++ b/components/signin/core/browser/signin_metrics.cc

@@ -102,4 +102,9 @@ void LogAuthError(GoogleServiceAuthError::State auth_error) {

GoogleServiceAuthError::State::NUM_STATES);

}

+void LogSigninConfirmHistogramValue(int action) {

+ UMA_HISTOGRAM_ENUMERATION("Signin.OneClickConfirmation", action,

+ signin_metrics::HISTOGRAM_CONFIRM_MAX);

} // namespace signin_metrics