components/signin/core/browser/signin_metrics.cc - Issue 914363003: Remove OneClickSigninHelper since it is no longer used.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/signin/core/browser/signin_metrics.cc

Issue 914363003: Remove OneClickSigninHelper since it is no longer used. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ocl

Patch Set: rebased Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/webui/signin/inline_login_handler_impl.cc ('K') | « components/signin/core/browser/signin_metrics.h ('k') | tools/perf/page_sets/tough_energy_cases.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "components/signin/core/browser/signin_metrics.h"	5 #include "components/signin/core/browser/signin_metrics.h"

6	6

7 #include "base/logging.h"	7 #include "base/logging.h"

8 #include "base/metrics/histogram.h"	8 #include "base/metrics/histogram.h"

9 #include "base/metrics/user_metrics.h"	9 #include "base/metrics/user_metrics.h"

10 #include "base/time/time.h"	10 #include "base/time/time.h"

(...skipping 84 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
95 "Signin.Reconciler.ExternalCcResultTime.NotCompleted",	95 "Signin.Reconciler.ExternalCcResultTime.NotCompleted",

96 time_to_check_connections);	96 time_to_check_connections);

97 }	97 }

98 }	98 }

99	99

100 void LogAuthError(GoogleServiceAuthError::State auth_error) {	100 void LogAuthError(GoogleServiceAuthError::State auth_error) {

101 UMA_HISTOGRAM_ENUMERATION("Signin.AuthError", auth_error,	101 UMA_HISTOGRAM_ENUMERATION("Signin.AuthError", auth_error,

102 GoogleServiceAuthError::State::NUM_STATES);	102 GoogleServiceAuthError::State::NUM_STATES);

103 }	103 }

104	104

	105 void LogSigninConfirmHistogramValue(int action) {

	106 UMA_HISTOGRAM_ENUMERATION("Signin.OneClickConfirmation", action,

	107 signin_metrics::HISTOGRAM_CONFIRM_MAX);

	108 }

	109

105 } // namespace signin_metrics	110 } // namespace signin_metrics

OLD	NEW