Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Unified Diff: chrome/app/chromeos_strings.grdp

Issue 914353004: Update import details panel to comply (mostly) with UX direction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/app/chromeos_strings.grdp
diff --git a/chrome/app/chromeos_strings.grdp b/chrome/app/chromeos_strings.grdp
index c7f629f494b7c6535e37ff3e5d707b09365ca8ba..158e83c2c3bc2b92c15bbe3671f52df15baadeba 100644
--- a/chrome/app/chromeos_strings.grdp
+++ b/chrome/app/chromeos_strings.grdp
@@ -448,25 +448,77 @@ Press any key to continue exploring.
<message name="IDS_FILE_BROWSER_CANCEL_SELECTION_BUTTON_LABEL" desc="Label for button that unselects all selected items.">
Cancel selection
</message>
- <message name="IDS_FILE_BROWSER_CLOUD_IMPORT_BUTTON_LABEL" desc="Label for button that initiates media backup to the cloud.">
- Import <ph name="FILE_COUNT">$1<ex>5</ex></ph> files to Google Drive
+ <message name="IDS_FILE_BROWSER_CLOUD_IMPORT_TITLE" desc="Title of the cloud import feature.">
mtomasz 2015/02/12 03:22:01 nit: feature -> dialog?
Steve McKay 2015/02/12 23:15:53 Used in a couple locations. So it is the general p
+ Cloud backup
mtomasz 2015/02/12 03:22:01 nit: What's the final naming? Back up backup or im
Steve McKay 2015/02/12 23:15:53 This is the final naming. "Cloud backup", but the
</message>
- <message name="IDS_FILE_BROWSER_CLOUD_IMPORT_ACTIVE_IMPORT_BUTTON_LABEL" desc="Message to user that there is an active import in progress.">
- Importing...
+ <message name="IDS_FILE_BROWSER_CLOUD_DESTINATION_FOLDER" desc="Title of the cloud import destination folder.">
+ ChromeOS Cloud backup
mtomasz 2015/02/12 03:22:00 nit: ChromeOS -> Chrome OS nit: Cloud backup -> cl
Steve McKay 2015/02/12 23:15:53 That's the title. I dunno why we treat title like
</message>
- <message name="IDS_FILE_BROWSER_CLOUD_IMPORT_EMPTY_SCAN_BUTTON_LABEL" desc="Message to user that no new files were found, so cloud import is not possible.">
- No new media
+ <message name="IDS_FILE_BROWSER_CLOUD_IMPORT_DESCRIPTION" desc="Short description of the cloud import feature.">
+ Back up your media device’s photos and videos to Google Drive.
</message>
- <message name="IDS_FILE_BROWSER_CLOUD_IMPORT_INSUFFICIENT_SPACE_BUTTON_LABEL" desc="Message to user that there is not enough space to perform a cloud import.">
- Insufficient space on your device!
+ <message name="IDS_FILE_BROWSER_CLOUD_IMPORT_START" desc="Tooltip of the toolbar button that starts backup.">
+ Backup your photos and videos.
mtomasz 2015/02/12 03:22:01 nit: Not period for tooltips?
Steve McKay 2015/02/12 23:15:53 Done.
</message>
- <message name="IDS_FILE_BROWSER_CLOUD_IMPORT_SCANNING_BUTTON_LABEL" desc="Label for button showing that scanning is in progress...prior to being enabled when scanning is complete.">
- Scanning your media...
+ <message name="IDS_FILE_BROWSER_CLOUD_IMPORT_SHOW_DETAILS" desc="Tooltip for button that shows details panel.">
+ Show Cloud backup details.
mtomasz 2015/02/12 03:22:00 nit: ditto
Steve McKay 2015/02/12 23:15:53 Done.
</message>
- <message name="IDS_FILE_BROWSER_CLOUD_IMPORT_ITEMS_REMAINING" desc="File Manager status message.">
- Importing <ph name="FILE_COUNT">$1<ex>5</ex></ph> files...
+ <message name="IDS_FILE_BROWSER_CLOUD_IMPORT_COMMAND" desc="Label of button on details panel that invokes cloud import feature.">
+ Back up
+ </message>
+ <message name="IDS_FILE_BROWSER_CLOUD_IMPORT_STATUS_SCANNING" desc="Cloud import scanning status message.">
+ <ph name="BEGIN_LINK">&lt;span class='leader'&gt;</ph>
mtomasz 2015/02/12 03:22:00 nit: Do we need the class name in strings?
Steve McKay 2015/02/12 23:15:53 It's better than having to pass it in. To be hones
+ Scanning your media device...
+ <ph name="END_LINK">&lt;/span&gt;</ph>
+ <ph name="FILE_COUNT">$1<ex>5</ex></ph> new photos found
+ </message>
+ <message name="IDS_FILE_BROWSER_CLOUD_IMPORT_TOOLTIP_SCANNING" desc="Cloud import scanning tooltip.">
+ Scanning your media device...
+ </message>
+ <message name="IDS_FILE_BROWSER_CLOUD_IMPORT_STATUS_NO_MEDIA" desc="Cloud import no-new-media-found status message.">
+ <ph name="BEGIN_LINK">&lt;span class='leader'&gt;</ph>All backed up!<ph name="END_LINK">&lt;/span&gt;</ph>
mtomasz 2015/02/12 03:22:01 nit: Remove span?
Steve McKay 2015/02/12 23:15:53 No, that's the end </span> tag. Again, need a real
+ </message>
+ <message name="IDS_FILE_BROWSER_CLOUD_IMPORT_TOOLTIP_NO_MEDIA" desc="Cloud import no-new-media-found tooltip.">
+ All backed up!
mtomasz 2015/02/12 03:22:00 nit: Why no media shows "All backed up!"? Could yo
Steve McKay 2015/02/12 23:15:53 Done.
+ </message>
+ <message name="IDS_FILE_BROWSER_CLOUD_IMPORT_STATUS_INSUFFICIENT_SPACE" desc="Cloud import insufficient space status message.">
+ <ph name="BEGIN_LINK">&lt;span class='leader'&gt;</ph>
+ <ph name="FILE_COUNT">$1<ex>5</ex></ph> new photos found
+ <ph name="END_LINK">&lt;/span&gt;</ph>
+ &lt;br&gt;
+ Not enough space on device.
+ &lt;br&gt;
+ Try selecting a few photos to start
mtomasz 2015/02/12 03:22:01 nit: period missing
Steve McKay 2015/02/12 23:15:53 Done.
+ </message>
+ <message name="IDS_FILE_BROWSER_CLOUD_IMPORT_TOOLTIP_INSUFFICIENT_SPACE" desc="Cloud import insufficient space tooltip.">
+ Not enough space on device.
mtomasz 2015/02/12 03:22:00 nit: No period for tooltips. nit: on device -> on
Steve McKay 2015/02/12 23:15:53 Done.
+ </message>
+ <message name="IDS_FILE_BROWSER_CLOUD_IMPORT_STATUS_READY" desc="Cloud import ready status message.">
+ <ph name="BEGIN_LINK">&lt;span class='leader'&gt;</ph>
mtomasz 2015/02/12 03:22:01 I think we are putting to much in strings. If we c
Steve McKay 2015/02/12 23:15:53 That makes things ever harder to manage from the c
+ <ph name="FILE_COUNT">$1<ex>5</ex></ph> new photos found
+ <ph name="END_LINK">&lt;/span&gt;</ph>
+ &lt;br&gt;
+ Ready to backup to <ph name="BEGIN_LINK">&lt;span class='destination-link'&gt;</ph>Google Drive<ph name="END_LINK">&lt;/span&gt;</ph>
mtomasz 2015/02/12 03:22:01 nit: Do we need a class name in this string?
Steve McKay 2015/02/12 23:15:53 Yes. In order to style this. Before I submit, I'm
+ </message>
+ <message name="IDS_FILE_BROWSER_CLOUD_IMPORT_TOOLTIP_READY" desc="Cloud import ready tooltip.">
+ Ready to backup <ph name="FILE_COUNT">$1<ex>5</ex></ph> new photos
+ </message>
+ <message name="IDS_FILE_BROWSER_CLOUD_IMPORT_STATUS_IMPORTING" desc="Cloud import active-backup status.">
mtomasz 2015/02/12 03:22:01 nit: People doing translations may not be familila
Steve McKay 2015/02/12 23:15:53 Done.
+ <ph name="BEGIN_LINK">&lt;span class='leader'&gt;</ph>
+ Backing up <ph name="FILE_COUNT">$1<ex>5</ex></ph> photos to <ph name="BEGIN_LINK">&lt;span class='destination-link'&gt;</ph>Google Drive<ph name="END_LINK">&lt;/span&gt;</ph>
+ <ph name="END_LINK">&lt;/span&gt;</ph>
+ </message>
+ <message name="IDS_FILE_BROWSER_CLOUD_IMPORT_TOOLTIP_IMPORTING" desc="Cloud import active-backup tooltip.">
+ Backing up <ph name="FILE_COUNT">$1<ex>5</ex></ph> photos
+ </message>
+ <message name="IDS_FILE_BROWSER_CLOUD_IMPORT_STATUS_DONE" desc="Cloud import backup is complete status.">
+ <ph name="BEGIN_LINK">&lt;span class='leader'&gt;</ph>
+ <ph name="FILE_COUNT">$1<ex>5</ex></ph> photos backed up to <ph name="BEGIN_LINK">&lt;span class='destination-link'&gt;</ph>Google Drive<ph name="END_LINK">&lt;/span&gt;</ph>
+ <ph name="END_LINK">&lt;/span&gt;</ph>
+ </message>
+ <message name="IDS_FILE_BROWSER_CLOUD_IMPORT_TOOLTIP_DONE" desc="Cloud import backup is complete tooltip.">
+ <ph name="FILE_COUNT">$1<ex>5</ex></ph> photos backed up
</message>
-
<message name="IDS_FILE_BROWSER_COPY_FILE_NAME" desc="File Manager status message.">
Copying <ph name="FILE_NAME">$1<ex>movie.avi</ex></ph>...
</message>

Powered by Google App Engine
This is Rietveld 408576698