tools/telemetry/telemetry/web_perf/metrics/fast_metric.py - Issue 914083005: [Telemetry] Fix 'important' field of certain Values being non-boolean

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/web_perf/metrics/fast_metric.py

Issue 914083005: [Telemetry] Fix 'important' field of certain Values being non-boolean (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Ned's comment Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/web_perf/metrics/fast_metric.py

diff --git a/tools/telemetry/telemetry/web_perf/metrics/fast_metric.py b/tools/telemetry/telemetry/web_perf/metrics/fast_metric.py

index 88b198918d969cc5f09a2e57c20c8f20f7b3816e..39d19a86b91e5b126f0605016e7b94b1a20fb2a0 100644

--- a/tools/telemetry/telemetry/web_perf/metrics/fast_metric.py

+++ b/tools/telemetry/telemetry/web_perf/metrics/fast_metric.py

@@ -82,20 +82,22 @@ class FastMetric(timeline_based_metric.TimelineBasedMetric):

results.AddValue(scalar.ScalarValue(

results.current_page, 'fast-' + event_stats.result_name, 'ms',

event_stats.thread_duration,

- event_stats.result_description))

+ description=event_stats.result_description))

results.AddValue(scalar.ScalarValue(

results.current_page,

'fast-' + event_stats.result_name + '_outside_idle', 'ms',

event_stats.thread_duration_outside_idle,

- event_stats.result_description + 'outside of idle notifications'))

+ description=(event_stats.result_description +

+ 'outside of idle notifications')))

results.AddValue(scalar.ScalarValue(

results.current_page, 'fast-total_garbage_collection', 'ms',

v8_stats.total_gc_thread_duration,

- 'Total thread duration of all garbage collection events'))

+ description='Total thread duration of all garbage collection events'))

results.AddValue(scalar.ScalarValue(

results.current_page, 'fast-total_garbage_collection_outside_idle',

'ms', v8_stats.total_gc_thread_duration_outside_idle,

- 'Total thread duration of all garbage collection events outside of idle'

- 'notifications'))

+ description=(

+ 'Total thread duration of all garbage collection events outside of '

+ 'idle notifications')))

« tools/telemetry/telemetry/value/__init__.py ('K') | « tools/telemetry/telemetry/value/value_unittest.py ('k') | no next file » | no next file with comments »