[Telemetry] Fix 'important' field of certain Values being non-boolean

tools/telemetry/telemetry/value/__init__.py

Index: tools/telemetry/telemetry/value/__init__.py
diff --git a/tools/telemetry/telemetry/value/__init__.py b/tools/telemetry/telemetry/value/__init__.py
index c4330ecdd92c5da1a3b24217ed9d5e43b2840694..64557c14c8195a2a57608853c1278afb1a24b235 100644
--- a/tools/telemetry/telemetry/value/__init__.py
+++ b/tools/telemetry/telemetry/value/__init__.py
@@ -57,6 +57,15 @@ class Value(object):
       description: A string explaining in human-understandable terms what this
           value represents.
     """
+    if page is not None:
+      # TODO(eakuefner): Change this to isinstance once page is refactored.
+      assert type(page).__name__ == 'Page'

[nednguyen, 2015/02/13 19:09:21]

Actually, let's left page alone for now because the abstraction we have been
cheating here is 'user_story' :-(

[eakuefner, 2015/02/13 19:29:13]

Fair enough. I did some fiddling in the bug tracker and also put a ref to the
bug in question here.

+    assert isinstance(name, str)
+    assert isinstance(units, str)
+    assert isinstance(important, bool)
+    if description is not None:
+      assert isinstance(description, str)

[nednguyen, 2015/02/13 19:09:21]

assert (not description) or isinstance(description, str)

[eakuefner, 2015/02/13 19:29:13]

Done, except I think (not description) is not quite correct because that will be
True if description is False so I've gone for (description is None).

+
     self.page = page
     self.name = name
     self.units = units