Tap on the video element toggles controls visibility

Source/core/html/shadow/MediaControlElements.h

Index: Source/core/html/shadow/MediaControlElements.h
diff --git a/Source/core/html/shadow/MediaControlElements.h b/Source/core/html/shadow/MediaControlElements.h
index 6db1d5882196dcf844d8556400cb0c85c97eb9cb..3ddc8f3ed1362c52743092ab7bf65b1b8236b5b0 100644
--- a/Source/core/html/shadow/MediaControlElements.h
+++ b/Source/core/html/shadow/MediaControlElements.h
@@ -45,6 +45,8 @@ public:
     void makeOpaque();
     void makeTransparent();
 
+    bool isOpaque() const { return m_opaque; }

[philipj_slow, 2015/02/16 10:45:18]

What about m_isDisplayed? I assume you want to check "are the controls currently
visible to the user" and unfortunately MediaControlPanelElement::makeOpaque()
involves two state bits.

[Tima Vaisburd, 2015/02/16 20:32:11]

Thank you, I did not pay enough attention to this. But, wouldn't it change the
behavior only for those taps that came in the middle of fading? 

[philipj_slow, 2015/02/17 02:37:24]

http://trac.webkit.org/changeset/115125 is where m_isDisplayed was added. I
think the idea is that makeOpaque can be called unconditionally wherever
something should trigger the controls to become visible, but unless
MediaControls::show() has been called it doesn't matter.

This is somewhat confusing and I could be wrong, but I think m_opaque &&
m_isDisplayed ought to mean that it's really visible. Maybe just inspecting
CSSPropertyDisplay and CSSPropertyOpacity would be easier.

+
 private:
     explicit MediaControlPanelElement(MediaControls&);