Tap on the video element toggles controls visibility

Source/core/html/shadow/MediaControlElements.h

 /*
  * Copyright (C) 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 27 matching lines @@
 
 class MediaControlPanelElement final : public MediaControlDivElement {
 public:
     static PassRefPtrWillBeRawPtr<MediaControlPanelElement> create(MediaControls&);
 
     void setIsDisplayed(bool);
 
     void makeOpaque();
     void makeTransparent();
 
+    bool isOpaque() const { return m_opaque; }

[philipj_slow, 2015/02/16 10:45:18]

What about m_isDisplayed? I assume you want to check "are the controls currently
visible to the user" and unfortunately MediaControlPanelElement::makeOpaque()
involves two state bits.

[Tima Vaisburd, 2015/02/16 20:32:11]

Thank you, I did not pay enough attention to this. But, wouldn't it change the
behavior only for those taps that came in the middle of fading? 

[philipj_slow, 2015/02/17 02:37:24]

http://trac.webkit.org/changeset/115125 is where m_isDisplayed was added. I
think the idea is that makeOpaque can be called unconditionally wherever
something should trigger the controls to become visible, but unless
MediaControls::show() has been called it doesn't matter.

This is somewhat confusing and I could be wrong, but I think m_opaque &&
m_isDisplayed ought to mean that it's really visible. Maybe just inspecting
CSSPropertyDisplay and CSSPropertyOpacity would be easier.

+
 private:
     explicit MediaControlPanelElement(MediaControls&);
 
     virtual void defaultEventHandler(Event*) override;
 
     void startTimer();
     void stopTimer();
     void transitionTimerFired(Timer<MediaControlPanelElement>*);
     virtual bool keepEventInNode(Event*) override;
 
@@ skipping 193 matching lines @@
     virtual LayoutObject* createRenderer(const LayoutStyle&) override;
 
     IntRect m_videoDisplaySize;
     float m_fontSize;
 };
 
 
 } // namespace blink
 
 #endif // MediaControlElements_h