Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 9139003: ninja/mac: Put dylibs directly into the product directory. (Closed)

Created:
8 years, 11 months ago by Nico
Modified:
8 years, 11 months ago
Reviewers:
Evan Martin
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

ninja/mac: Put dylibs directly into the product directory. This matches xcode and make, and the chrome build depends on this. Like http://codereview.chromium.org/7395025 , except that I'm now also writing the test I should've written back then. BUG=chromium:96894 Committed: http://code.google.com/p/gyp/source/detail?r=1133

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -11 lines) Patch
M pylib/gyp/generator/ninja.py View 1 2 3 4 2 chunks +7 lines, -8 lines 0 comments Download
M test/lib/TestGyp.py View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
A test/mac/copy-dylib/empty.c View 1 chunk +1 line, -0 lines 0 comments Download
A test/mac/copy-dylib/test.gyp View 1 chunk +31 lines, -0 lines 0 comments Download
A test/mac/gyptest-copy-dylib.py View 1 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
8 years, 11 months ago (2012-01-06 18:43:11 UTC) #1
Evan Martin
http://codereview.chromium.org/9139003/diff/3006/pylib/gyp/generator/ninja.py File pylib/gyp/generator/ninja.py (right): http://codereview.chromium.org/9139003/diff/3006/pylib/gyp/generator/ninja.py#newcode733 pylib/gyp/generator/ninja.py:733: # too. Should we instead compute some sort of ...
8 years, 11 months ago (2012-01-06 18:50:00 UTC) #2
Nico
http://codereview.chromium.org/9139003/diff/3006/pylib/gyp/generator/ninja.py File pylib/gyp/generator/ninja.py (right): http://codereview.chromium.org/9139003/diff/3006/pylib/gyp/generator/ninja.py#newcode733 pylib/gyp/generator/ninja.py:733: # too. On 2012/01/06 18:50:00, Evan Martin wrote: > ...
8 years, 11 months ago (2012-01-06 18:54:49 UTC) #3
Evan Martin
8 years, 11 months ago (2012-01-06 18:59:44 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698