Issue 7395025: make: Put shared_libraries into PRODUCT_DIR on mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7395025: make: Put shared_libraries into PRODUCT_DIR on mac. (Closed)

Created:
9 years, 5 months ago by Nico

Modified:
9 years, 5 months ago

Reviewers:
Evan Martin

CC:
gyp-developer_googlegroups.com, Mark Mentovai

Base URL:
http://gyp.googlecode.com/svn/trunk/

Visibility:
Public.

Description

make: Put shared_libraries into PRODUCT_DIR on mac. Xcode puts shared_library results into PRODUCT_DIR, and some gyp files rely on this. Emulate this behavior for mac. Committed: http://code.google.com/p/gyp/source/detail?r=953

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
	M	pylib/gyp/generator/make.py	View	1	4 chunks	+6 lines, -2 lines	0 comments	Download
	M	test/lib/TestGyp.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nico

9 years, 5 months ago (2011-07-18 16:09:46 UTC) #3

I noticed this broke the gyp tests. I uploaded an updated patch, maybe take
another look.

Expand Messages | Collapse Messages