Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 91373004: Move DBusClient stub implementations into separate files. (Closed)

Created:
7 years ago by pneubeck (no reviews)
Modified:
7 years ago
Reviewers:
satorux1
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Move DBusClient stub implementations into separate files. This allows to create these stubs directly without routing through the static Create() function in the client's interface. BUG=275286 R=satorux@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238329

Patch Set 1 : #

Patch Set 2 : Fix SMS unittest. #

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+437 lines, -396 lines) Patch
M chromeos/chromeos.gyp View 1 2 3 chunks +10 lines, -0 lines 0 comments Download
M chromeos/dbus/dbus_thread_manager.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M chromeos/dbus/debug_daemon_client.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/dbus/debug_daemon_client.cc View 3 chunks +8 lines, -96 lines 0 comments Download
M chromeos/dbus/fake_cros_disks_client.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/dbus/fake_dbus_thread_manager.cc View 4 chunks +13 lines, -13 lines 0 comments Download
A chromeos/dbus/fake_debug_daemon_client.h View 1 chunk +56 lines, -0 lines 0 comments Download
A chromeos/dbus/fake_debug_daemon_client.cc View 1 chunk +116 lines, -0 lines 0 comments Download
A + chromeos/dbus/fake_introspectable_client.h View 1 chunk +13 lines, -13 lines 0 comments Download
A + chromeos/dbus/fake_introspectable_client.cc View 1 chunk +11 lines, -21 lines 0 comments Download
A + chromeos/dbus/fake_modem_messaging_client.h View 2 chunks +15 lines, -41 lines 0 comments Download
A chromeos/dbus/fake_modem_messaging_client.cc View 1 chunk +64 lines, -0 lines 0 comments Download
A + chromeos/dbus/fake_permission_broker_client.h View 1 chunk +17 lines, -13 lines 0 comments Download
A + chromeos/dbus/fake_permission_broker_client.cc View 1 chunk +18 lines, -8 lines 0 comments Download
A + chromeos/dbus/fake_sms_client.h View 1 chunk +18 lines, -11 lines 0 comments Download
A chromeos/dbus/fake_sms_client.cc View 1 chunk +55 lines, -0 lines 0 comments Download
M chromeos/dbus/introspectable_client.h View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/introspectable_client.cc View 2 chunks +2 lines, -20 lines 0 comments Download
M chromeos/dbus/modem_messaging_client.h View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/modem_messaging_client.cc View 2 chunks +2 lines, -68 lines 0 comments Download
M chromeos/dbus/modem_messaging_client_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chromeos/dbus/permission_broker_client.h View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/permission_broker_client.cc View 1 chunk +2 lines, -28 lines 0 comments Download
M chromeos/dbus/sms_client.h View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/sms_client.cc View 3 chunks +3 lines, -49 lines 0 comments Download
M chromeos/network/network_sms_handler_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
pneubeck (no reviews)
ptal
7 years ago (2013-11-29 09:12:20 UTC) #1
satorux1
lgtm
7 years ago (2013-12-03 04:02:20 UTC) #2
pneubeck (no reviews)
7 years ago (2013-12-03 09:56:12 UTC) #3
Message was sent while issue was closed. 
Committed patchset #3 manually as r238329 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698