Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Unified Diff: chromeos/dbus/introspectable_client.cc

Issue 91373004: Move DBusClient stub implementations into separate files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/dbus/introspectable_client.h ('k') | chromeos/dbus/modem_messaging_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/introspectable_client.cc
diff --git a/chromeos/dbus/introspectable_client.cc b/chromeos/dbus/introspectable_client.cc
index 81cc8a15eda406f88e7835965edfa776b5df25fc..ddc548485695a919e18be41d8600cd338da6b87d 100644
--- a/chromeos/dbus/introspectable_client.cc
+++ b/chromeos/dbus/introspectable_client.cc
@@ -91,20 +91,6 @@ class IntrospectableClientImpl : public IntrospectableClient {
DISALLOW_COPY_AND_ASSIGN(IntrospectableClientImpl);
};
-// The IntrospectableClient implementation used on Linux desktop, which does
-// nothing.
-class IntrospectableClientStubImpl : public IntrospectableClient {
- public:
- // IntrospectableClient override.
- virtual void Init(dbus::Bus* bus) OVERRIDE {}
- virtual void Introspect(const std::string& service_name,
- const dbus::ObjectPath& object_path,
- const IntrospectCallback& callback) OVERRIDE {
- VLOG(1) << "Introspect: " << service_name << " " << object_path.value();
- callback.Run(service_name, object_path, "", false);
- }
-};
-
IntrospectableClient::IntrospectableClient() {
}
@@ -145,12 +131,8 @@ IntrospectableClient::GetInterfacesFromIntrospectResult(
}
// static
-IntrospectableClient* IntrospectableClient::Create(
- DBusClientImplementationType type) {
- if (type == REAL_DBUS_CLIENT_IMPLEMENTATION)
- return new IntrospectableClientImpl();
- DCHECK_EQ(STUB_DBUS_CLIENT_IMPLEMENTATION, type);
- return new IntrospectableClientStubImpl();
+IntrospectableClient* IntrospectableClient::Create() {
+ return new IntrospectableClientImpl();
}
} // namespace chromeos
« no previous file with comments | « chromeos/dbus/introspectable_client.h ('k') | chromeos/dbus/modem_messaging_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698