Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 913723002: [MIPS] Fix syscall clone implementation (Closed)

Created:
5 years, 10 months ago by petarj
Modified:
5 years, 10 months ago
CC:
chromium-reviews, Markus (顧孟勤), gordana.cmiljanovic_imgtec.com
Visibility:
Public.

Description

[MIPS] Fix syscall clone implementation After compiling lss with Clang/LLVM, two issues came up: a) clang complains about named register __r7 being listed both as input argument and input-output argument, and b) clang does weird things if input argument is not actually initialized before asm block. This change fixes those two issues by removing __r7 from the input argument list and by moving __v0 initialization out of asm block.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -17 lines) Patch
M lss/linux_syscall_support.h View 5 chunks +16 lines, -17 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
petarj
5 years, 10 months ago (2015-02-10 15:20:21 UTC) #2
petarj
ping.
5 years, 10 months ago (2015-02-12 13:28:46 UTC) #3
petarj
On 2015/02/12 13:28:46, petarj wrote: > ping. ping.
5 years, 10 months ago (2015-02-18 17:17:08 UTC) #5
Mark Seaborn
On 2015/02/18 17:17:08, petarj wrote: > On 2015/02/12 13:28:46, petarj wrote: > > ping. > ...
5 years, 10 months ago (2015-02-18 17:27:40 UTC) #6
petarj
On 2015/02/18 17:27:40, Mark Seaborn wrote: > On 2015/02/18 17:17:08, petarj wrote: > > On ...
5 years, 10 months ago (2015-02-18 18:02:28 UTC) #7
vapier
it still builds with clang, and the changes look pretty mechanical. plus the patch is ...
5 years, 10 months ago (2015-02-20 20:44:09 UTC) #8
vapier
committed in: https://code.google.com/p/linux-syscall-support/source/detail?r=34
5 years, 10 months ago (2015-02-20 20:46:49 UTC) #9
vapier
btw, in exchange, could you review https://code.google.com/p/linux-syscall-support/issues/detail?id=5 ? ;)
5 years, 10 months ago (2015-02-20 20:49:28 UTC) #10
petarj
5 years, 10 months ago (2015-02-24 00:21:03 UTC) #11
Message was sent while issue was closed.
On 2015/02/20 20:46:49, vapier wrote:
> committed in:
https://code.google.com/p/linux-syscall-support/source/detail?r=34

Thanks. You did not really need to commit it, since I have commit rights as
well. :)

Powered by Google App Engine
This is Rietveld 408576698