Clean up clipping code a bit

Clean up clipping code a bit

Committed: https://skia.googlesource.com/skia/+/e85a32d4f8ce7fb9b6aaae89137dbf3766d833f2

[robertphillips, 2015-02-10 14:07:52]

robertphillips@google.com changed reviewers:
+ bsalomon@google.com

[robertphillips, 2015-02-10 14:54:07]

https://codereview.chromium.org/913693002/diff/20001/src/core/SkClipStack.cpp
File src/core/SkClipStack.cpp (right):

https://codereview.chromium.org/913693002/diff/20001/src/core/SkClipStack.cpp...
src/core/SkClipStack.cpp:422: if (!fDoAA) {
Just FYI - if we replace the 0.45f oddness with an SkScalarRoundToScalar we get
an assert in the SW clip mask creation process where raster's idea of the clip
bounds differ from ours (i.e., it is trying to index to (-1, *) when creating
the mask).

[bsalomon, 2015-02-10 15:57:24]

lgtm

https://codereview.chromium.org/913693002/diff/20001/src/core/SkClipStack.cpp
File src/core/SkClipStack.cpp (right):

https://codereview.chromium.org/913693002/diff/20001/src/core/SkClipStack.cpp...
src/core/SkClipStack.cpp:422: if (!fDoAA) {
On 2015/02/10 14:54:07, robertphillips wrote:
> Just FYI - if we replace the 0.45f oddness with an SkScalarRoundToScalar we
get
> an assert in the SW clip mask creation process where raster's idea of the clip
> bounds differ from ours (i.e., it is trying to index to (-1, *) when creating
> the mask).

eek, do we know why that happens?

[robertphillips, 2015-02-10 16:10:35]

> eek, do we know why that happens?

I haven't looked to deeply into it yet. I'm going to push it down as close to
the SW mask creation as possible though (so only it needs to know about the
craziness).

[robertphillips, 2015-02-10 16:10:41]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2015-02-10 16:11:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/913693002/20001

[commit-bot: I haz the power, 2015-02-10 16:16:58]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/e85a32d4f8ce7fb9b6aaae89137dbf3766d833f2