Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1276)

Unified Diff: Source/core/html/canvas/WebGLSync.cpp

Issue 913603003: Make WebGL2 objects Oilpan compatible. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/canvas/WebGLSync.cpp
diff --git a/Source/core/html/canvas/WebGLSync.cpp b/Source/core/html/canvas/WebGLSync.cpp
index 6df45da40364292ef5ba00b3e37e5e1c67694fcf..8b0d95022196611d2fb35b761288d96a66bb1de2 100644
--- a/Source/core/html/canvas/WebGLSync.cpp
+++ b/Source/core/html/canvas/WebGLSync.cpp
@@ -12,7 +12,14 @@ namespace blink {
WebGLSync::~WebGLSync()
{
- deleteObject(0);
+ // Always call detach here to ensure that platform object deletion
+ // happens with Oilpan enabled. It keeps the code regular to do it
+ // with or without Oilpan enabled.
+ //
+ // See comment in WebGLBuffer's destructor for additional
+ // information on why this is done for WebGLSharedObject-derived
+ // objects.
+ detachAndDeleteObject();
}
WebGLSync::WebGLSync(WebGL2RenderingContextBase* ctx, GLenum objectType)

Powered by Google App Engine
This is Rietveld 408576698