Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 913593002: Don't fire error messages if an install kills Chrome (Closed)

Created:
5 years, 10 months ago by gone
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't fire error messages if an install kills Chrome Die silently if the Play Store starts installing an app promoted by the webpage and Chrome dies in the background before returning. In this case, the infobar will disappear before the user gets back anyway. BUG=453170 Committed: https://crrev.com/11c081ff9dcf24b3fd9a530af0ea2badf013c6c6 Cr-Commit-Position: refs/heads/master@{#315406}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -12 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java View 2 chunks +2 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
gone
5 years, 10 months ago (2015-02-09 19:52:25 UTC) #2
David Trainor- moved to gerrit
lgtm
5 years, 10 months ago (2015-02-09 21:24:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/913593002/1
5 years, 10 months ago (2015-02-09 21:37:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-09 22:15:30 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 22:16:16 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/11c081ff9dcf24b3fd9a530af0ea2badf013c6c6
Cr-Commit-Position: refs/heads/master@{#315406}

Powered by Google App Engine
This is Rietveld 408576698